Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: content/child/web_url_loader_impl_unittest.cc

Issue 766963003: Revert of Properly handle defers loading in WebURLLoaderImpl for data uris (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/web_url_loader_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/web_url_loader_impl_unittest.cc
diff --git a/content/child/web_url_loader_impl_unittest.cc b/content/child/web_url_loader_impl_unittest.cc
index 0d4780ad0b0c2eaf9215e018c6f459acd95a45a6..e44a000797ed81a2a40f48445e7124e61c2db6dc 100644
--- a/content/child/web_url_loader_impl_unittest.cc
+++ b/content/child/web_url_loader_impl_unittest.cc
@@ -507,7 +507,7 @@
EXPECT_FALSE(bridge());
}
-TEST_F(WebURLLoaderImplTest, DataURLDeleteOnFinish) {
+TEST_F(WebURLLoaderImplTest, DataURLDeleteOnFinisha) {
blink::WebURLRequest request;
request.initialize();
request.setURL(GURL("data:text/html;charset=utf-8,blah!"));
@@ -518,25 +518,6 @@
EXPECT_EQ("blah!", client()->received_data());
EXPECT_TRUE(client()->did_finish());
EXPECT_FALSE(bridge());
-}
-
-TEST_F(WebURLLoaderImplTest, DataURLDefersLoading) {
- blink::WebURLRequest request;
- request.initialize();
- request.setURL(GURL("data:text/html;charset=utf-8,blah!"));
- client()->loader()->loadAsynchronously(request, client());
-
- client()->loader()->setDefersLoading(true);
- message_loop()->RunUntilIdle();
- EXPECT_FALSE(client()->did_finish());
-
- client()->loader()->setDefersLoading(false);
- message_loop()->RunUntilIdle();
- EXPECT_TRUE(client()->did_finish());
-
- EXPECT_EQ("blah!", client()->received_data());
- EXPECT_EQ(net::OK, client()->error().reason);
- EXPECT_EQ("", client()->error().domain.utf8());
}
// FTP integration tests. These are focused more on safe deletion than correct
« no previous file with comments | « content/child/web_url_loader_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698