Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 766943003: Remove uses of PaintBehaviorFlattenCompositingLayers (Closed)

Created:
6 years ago by rafaelw
Modified:
6 years ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : cr comments #

Patch Set 3 : patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -98 lines) Patch
M sky/engine/core/rendering/InlineFlowBox.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/InlineFlowBox.cpp View 1 5 chunks +10 lines, -31 lines 0 comments Download
M sky/engine/core/rendering/PaintPhase.h View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 1 3 chunks +7 lines, -35 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.cpp View 1 8 chunks +13 lines, -12 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 1 2 1 chunk +1 line, -10 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rafaelw
6 years ago (2014-11-29 04:58:21 UTC) #2
ojan
lgtm https://codereview.chromium.org/766943003/diff/1/sky/engine/core/rendering/RenderBox.cpp File sky/engine/core/rendering/RenderBox.cpp (right): https://codereview.chromium.org/766943003/diff/1/sky/engine/core/rendering/RenderBox.cpp#newcode925 sky/engine/core/rendering/RenderBox.cpp:925: paintNinePieceImage(paintInfo.context, paintRect, style(), style()->maskBoxImage(), CompositeSourceOver); Do paintFillLayers and/or ...
6 years ago (2014-12-01 19:00:38 UTC) #3
rafaelw
https://codereview.chromium.org/766943003/diff/1/sky/engine/core/rendering/RenderBox.cpp File sky/engine/core/rendering/RenderBox.cpp (right): https://codereview.chromium.org/766943003/diff/1/sky/engine/core/rendering/RenderBox.cpp#newcode925 sky/engine/core/rendering/RenderBox.cpp:925: paintNinePieceImage(paintInfo.context, paintRect, style(), style()->maskBoxImage(), CompositeSourceOver); On 2014/12/01 19:00:38, ojan ...
6 years ago (2014-12-01 19:26:11 UTC) #4
ojan
lgtm I expect we can simplify some of GraphicsContext as well now to pass fewer ...
6 years ago (2014-12-01 19:30:30 UTC) #5
rafaelw
6 years ago (2014-12-01 19:49:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
c5d377fbb78329be42a7c1d5a95edb893be63fad.

Powered by Google App Engine
This is Rietveld 408576698