Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 7669024: Diagnose EBADF before EFAULT (Closed)

Created:
9 years, 4 months ago by Roland McGrath
Modified:
9 years, 4 months ago
Reviewers:
bsy
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Diagnose EBADF before EFAULT This is consistent with traditional Unix behavior, and with what's possible when the user-visible file descriptor layer is implemented in untrusted code. BUG= none TEST= trybots R=bsy@google.com Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=6461

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -35 lines) Patch
M src/trusted/service_runtime/nacl_syscall_common.c View 8 chunks +40 lines, -32 lines 0 comments Download
M tests/syscalls/syscalls.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Roland McGrath
9 years, 4 months ago (2011-08-17 17:30:32 UTC) #1
bsy
9 years, 4 months ago (2011-08-17 17:48:25 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698