Serializer: cache recent back references for shorter encoding.

Serializer: cache recent back references for shorter encoding.

And some refactorings.

R=mvstanton@chromium.org

[Yang, 2014-12-02 07:53:29]

On 2014/11/28 12:37:22, Yang wrote:

ping

[mvstanton, 2014-12-03 08:22:41]

lgtm with nits.

https://codereview.chromium.org/766893002/diff/20001/src/serialize.cc
File src/serialize.cc (right):

https://codereview.chromium.org/766893002/diff/20001/src/serialize.cc#newcode...
src/serialize.cc:1467: if (FLAG_trace_serializer) {
I thought it was FLAG_trace_code_serializer?

https://codereview.chromium.org/766893002/diff/20001/src/serialize.cc#newcode...
src/serialize.cc:2054: if (FLAG_trace_serializer) {
FLAG_trace_serializer or FLAG_trace_code_serializer, either one is fine so long
as it compiles :).

https://codereview.chromium.org/766893002/diff/20001/src/serialize.h
File src/serialize.h (right):

https://codereview.chromium.org/766893002/diff/20001/src/serialize.h#newcode628
src/serialize.h:628: bool SerializeKnownObject(HeapObject* obj, HowToCode
how_to_code,
Can you comment the return value, something like: "returns true if the object
was successfully serialized."

https://codereview.chromium.org/766893002/diff/20001/src/snapshot-source-sink.h
File src/snapshot-source-sink.h (right):

https://codereview.chromium.org/766893002/diff/20001/src/snapshot-source-sink...
src/snapshot-source-sink.h:27: uint8_t Get() {
For simplicity, can the List<byte> below be a List<uint8_t>, or alternatively,
make Get() return byte.

[Yang, 2014-12-03 08:45:07]

https://codereview.chromium.org/766893002/diff/20001/src/serialize.cc
File src/serialize.cc (right):

https://codereview.chromium.org/766893002/diff/20001/src/serialize.cc#newcode...
src/serialize.cc:1467: if (FLAG_trace_serializer) {
On 2014/12/03 08:22:41, mvstanton wrote:
> I thought it was FLAG_trace_code_serializer?

You are right. I renamed it because this flag now affects all serializers, not
only the code serializer.

https://codereview.chromium.org/766893002/diff/20001/src/serialize.h
File src/serialize.h (right):

https://codereview.chromium.org/766893002/diff/20001/src/serialize.h#newcode628
src/serialize.h:628: bool SerializeKnownObject(HeapObject* obj, HowToCode
how_to_code,
On 2014/12/03 08:22:41, mvstanton wrote:
> Can you comment the return value, something like: "returns true if the object
> was successfully serialized."

Done.

https://codereview.chromium.org/766893002/diff/20001/src/snapshot-source-sink.h
File src/snapshot-source-sink.h (right):

https://codereview.chromium.org/766893002/diff/20001/src/snapshot-source-sink...
src/snapshot-source-sink.h:27: uint8_t Get() {
On 2014/12/03 08:22:41, mvstanton wrote:
> For simplicity, can the List<byte> below be a List<uint8_t>, or alternatively,
> make Get() return byte.

Done.

[Yang, 2014-12-03 08:45:13]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2014-12-03 08:45:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/766893002/40001

[commit-bot: I haz the power, 2014-12-03 09:12:36]

Committed patchset #3 (id:40001)