Added a call to ActivityManager.isLowRamDevice() from SysUtils.detectLowEndDevice()

Added a call to ActivityManager.isLowRamDevice() from SysUtils.detectLowEndDevice().

This patch adds an extra check to the SysUtils.detectLowEndDevice() method
(if no command-line flag is supplied). If ActivityManager.isLowRamDevice()
returns true, the method returns true (without checking device memory size).

BUG=

Committed: https://crrev.com/80dc8d87cfd1ef70541c101a355965f3a7a74415
Cr-Commit-Position: refs/heads/master@{#306592}

[petrcermak, 2014-11-28 11:25:03]

petrcermak@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[petrcermak, 2014-11-28 11:25:04]

Hi, please take a look at this small CL.

Thanks,
Petr

[rmcilroy, 2014-11-28 13:39:34]

https://codereview.chromium.org/766873002/diff/1/base/android/java/src/org/ch...
File base/android/java/src/org/chromium/base/SysUtils.java (right):

https://codereview.chromium.org/766873002/diff/1/base/android/java/src/org/ch...
base/android/java/src/org/chromium/base/SysUtils.java:128: } catch (Exception e)
{
Are there any checked exceptions which can be thrown here?  If not, you
shouldn't be try/catching.  We prefer to fail early rather than do defensive
programming unless it is expected that there will be failures.

[petrcermak, 2014-12-01 10:36:40]

+picksi
+ssid

[petrcermak, 2014-12-01 16:08:45]

Thanks for your comments. PTAL.

Petr

https://codereview.chromium.org/766873002/diff/1/base/android/java/src/org/ch...
File base/android/java/src/org/chromium/base/SysUtils.java (right):

https://codereview.chromium.org/766873002/diff/1/base/android/java/src/org/ch...
base/android/java/src/org/chromium/base/SysUtils.java:128: } catch (Exception e)
{
On 2014/11/28 13:39:34, rmcilroy wrote:
> Are there any checked exceptions which can be thrown here?  If not, you
> shouldn't be try/catching.  We prefer to fail early rather than do defensive
> programming unless it is expected that there will be failures.

No, I removed the try/catch statement.

[rmcilroy, 2014-12-03 11:14:05]

On 2014/12/01 16:08:45, petrcermak wrote:
> Thanks for your comments. PTAL.
> 
> Petr
> 
>
https://codereview.chromium.org/766873002/diff/1/base/android/java/src/org/ch...
> File base/android/java/src/org/chromium/base/SysUtils.java (right):
> 
>
https://codereview.chromium.org/766873002/diff/1/base/android/java/src/org/ch...
> base/android/java/src/org/chromium/base/SysUtils.java:128: } catch (Exception
e)
> {
> On 2014/11/28 13:39:34, rmcilroy wrote:
> > Are there any checked exceptions which can be thrown here?  If not, you
> > shouldn't be try/catching.  We prefer to fail early rather than do defensive
> > programming unless it is expected that there will be failures.
> 
> No, I removed the try/catch statement.

lgtm, thanks!

[petrcermak, 2014-12-03 11:22:51]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2014-12-03 11:23:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/766873002/20001

[commit-bot: I haz the power, 2014-12-03 12:25:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-03 12:25:57]

Patchset 2 (id:??) landed as
https://crrev.com/80dc8d87cfd1ef70541c101a355965f3a7a74415
Cr-Commit-Position: refs/heads/master@{#306592}

[no sievers, 2015-02-18 22:22:34]

Just wondering since it doesn't say anything and no bug is referenced: but why
was this done?