Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 766833003: ozone: dri: Remove distinction between root_location and location (Closed)

Created:
6 years ago by spang
Modified:
6 years ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ozone: dri: Remove distinction between root_location and location Aura expects these to be the same, so just use location() everywhere. This shouldn't affect anything because although we were passing along screen location inside root_location(), Event::UpdateForRootTransform sets it back to the transformed location(). So no code actually saw our screen location. BUG=none TEST=unit tests, manual on link_freon with 2 monitors Committed: https://crrev.com/8019c703c77f9a689f1f3d4d6527167479e8bb9e Cr-Commit-Position: refs/heads/master@{#308149}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ui/ozone/platform/dri/dri_window.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
spang
6 years ago (2014-12-05 22:57:37 UTC) #2
sadrul
lgtm
6 years ago (2014-12-11 14:59:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/766833003/1
6 years ago (2014-12-12 18:48:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 20:17:58 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-12 20:18:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8019c703c77f9a689f1f3d4d6527167479e8bb9e
Cr-Commit-Position: refs/heads/master@{#308149}

Powered by Google App Engine
This is Rietveld 408576698