remove references to DEPRECATED SkBitmap::kA1_Config. No functional change expected.

remove references to DEPRECATED SkBitmap::kA1_Config. No functional change expected.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236819

[danakj, 2013-11-20 00:16:28]

https://codereview.chromium.org/76683003/diff/1/ui/gfx/ozone/dri/dri_skbitmap.cc
File ui/gfx/ozone/dri/dri_skbitmap.cc (right):

https://codereview.chromium.org/76683003/diff/1/ui/gfx/ozone/dri/dri_skbitmap...
ui/gfx/ozone/dri/dri_skbitmap.cc:192: //    case SkBitmap::kA1_Config:    //
kA1_Config is DEPRECATED
why not just remove it?

[danakj, 2013-11-20 00:17:12]

https://codereview.chromium.org/76683003/diff/1/ui/message_center/views/notif...
File ui/message_center/views/notification_view.cc (left):

https://codereview.chromium.org/76683003/diff/1/ui/message_center/views/notif...
ui/message_center/views/notification_view.cc:115:
alpha.setConfig(SkBitmap::kA1_Config, bitmap.width(), bitmap.height(), 0);
This seems odd, what is setting the config/width/height then?

[rjkroege, 2013-11-20 01:24:45]

https://codereview.chromium.org/76683003/diff/1/ui/gfx/ozone/dri/dri_skbitmap.cc
File ui/gfx/ozone/dri/dri_skbitmap.cc (right):

https://codereview.chromium.org/76683003/diff/1/ui/gfx/ozone/dri/dri_skbitmap...
ui/gfx/ozone/dri/dri_skbitmap.cc:192: //    case SkBitmap::kA1_Config:    //
kA1_Config is DEPRECATED
On 2013/11/20 00:16:28, danakj wrote:
> why not just remove it?

I concur.

[reed1, 2013-11-20 16:07:30]

https://codereview.chromium.org/76683003/diff/1/ui/gfx/ozone/dri/dri_skbitmap.cc
File ui/gfx/ozone/dri/dri_skbitmap.cc (right):

https://codereview.chromium.org/76683003/diff/1/ui/gfx/ozone/dri/dri_skbitmap...
ui/gfx/ozone/dri/dri_skbitmap.cc:192: //    case SkBitmap::kA1_Config:    //
kA1_Config is DEPRECATED
On 2013/11/20 01:24:45, rjkroege wrote:
> On 2013/11/20 00:16:28, danakj wrote:
> > why not just remove it?
> 
> I concur.

Will do

https://codereview.chromium.org/76683003/diff/1/ui/message_center/views/notif...
File ui/message_center/views/notification_view.cc (left):

https://codereview.chromium.org/76683003/diff/1/ui/message_center/views/notif...
ui/message_center/views/notification_view.cc:115:
alpha.setConfig(SkBitmap::kA1_Config, bitmap.width(), bitmap.height(), 0);
On 2013/11/20 00:17:13, danakj wrote:
> This seems odd, what is setting the config/width/height then?

extractBitmap takes care of sizing and allocating the result. The current
settings are ignored (i.e. we could have removed this line long before this
deprecation CL).

[reed1, 2013-11-20 20:37:39]

PTAL -- I don't think the failures in the trys are related to this CL

[rjkroege, 2013-11-20 20:59:40]

ozone changes lgtm

[reed1, 2013-11-20 21:58:30]

danakj, have I addressed your questions?

[danakj, 2013-11-21 00:18:12]

Yes thanks, LGTM but you'll need some other owners too.

https://codereview.chromium.org/76683003/diff/80001/chrome/browser/ui/app_lis...
File chrome/browser/ui/app_list/fast_show_pickler.cc (right):

https://codereview.chromium.org/76683003/diff/80001/chrome/browser/ui/app_lis...
chrome/browser/ui/app_list/fast_show_pickler.cc:21: //  A1, // kA1_Config is
DEPRECATED
Same here, this should be removed rather than left as a comment.

[commit-bot: I haz the power, 2013-11-21 18:43:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reed@google.com/76683003/80001

[commit-bot: I haz the power, 2013-11-21 18:58:46]

Failed to trigger a try job on chromium_presubmit
HTTP Error 400: Bad Request

[reed1, 2013-11-21 19:07:28]

looking for owners reviews:

benwells@chromium.org
koz@chromium.org
tapted@chromium.org
xiyuan@chromium.org


dewittj@chromium.org
miket@chromium.org
mukai@chromium.org
stevenjb@chromium.org

[Jun Mukai, 2013-11-21 19:42:54]

ui/message_center: lgtm if no functional change.

[reed1, 2013-11-21 22:10:23]

need reviewer/owner for chrome/browser/ui/app_list ...

[reed1, 2013-11-22 16:25:18]

Darin, can you review this as an owner?

[jam, 2013-11-22 18:08:28]

chrome lgtm

[commit-bot: I haz the power, 2013-11-22 18:10:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reed@google.com/76683003/250001

[commit-bot: I haz the power, 2013-11-22 20:35:05]

Change committed as 236819