Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 766823004: Switch back to PrintDlgEx instead of DocumentProperties. (Closed)

Created:
6 years ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Switch back to PrintDlgEx instead of DocumentProperties. For unclear reasons DocumentProperties with DM_IN_PROMPT sometimes does not return. This is happening mostly on 32bit Windows inside of base::MessageLoop::ScopedNestableTaskAllower. BUG=436810 Committed: https://crrev.com/12b875862044115add059e1dd1478be089c2f64d Cr-Commit-Position: refs/heads/master@{#307294}

Patch Set 1 #

Patch Set 2 : Mon Dec 8 10:05:14 PST 2014 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M printing/printing_context_win.cc View 1 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Vitaly Buka (NO REVIEWS)
6 years ago (2014-12-07 10:04:20 UTC) #2
Aleksey Shlyapnikov
lgtm
6 years ago (2014-12-08 18:02:23 UTC) #4
Vitaly Buka (NO REVIEWS)
6 years ago (2014-12-08 18:05:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/766823004/20001
6 years ago (2014-12-08 18:07:29 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-08 18:57:16 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/12b875862044115add059e1dd1478be089c2f64d Cr-Commit-Position: refs/heads/master@{#307294}
6 years ago (2014-12-08 18:58:00 UTC) #10
Aleksey Shlyapnikov
6 years ago (2014-12-10 22:37:25 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698