Scroll text field when selecting text

Scroll text field when selecting text

BUG=437284
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188386

[Mathias Hällman, 2014-11-27 15:09:00]

mathiash@opera.com changed reviewers:
+ aelias@chromium.org, jochen@chromium.org

[Mathias Hällman, 2014-11-27 15:12:07]

jochen, aelias, could either of you have a look at this? I basically added the
UserTriggered flag, as that's what moveCaretSelection (see bug) is doing a few
lines down and I can't see how this one can be any less user triggered than that
one.

[jochen (gone - plz use gerrit), 2014-11-28 13:08:34]

is it possible to add a test for this?

[Mathias Hällman, 2014-11-28 13:54:53]

On 2014/11/28 13:08:34, jochen (slow) wrote:
> is it possible to add a test for this?

Possibly, but I'm not sure what such a test would look like and looking at
Source/web/tests/WebFrameTest.cpp there's nothing for moveCaretSelection that I
can mimic. Any of you care to give a hint?

[aelias_OOO_until_Jul13, 2014-12-01 20:14:10]

I guess the test would need to load in some HTML with a textbox, select text in
it, move the selection around and then assert that the textbox's scroll offset
has moved.

[Mathias Hällman, 2015-01-12 11:59:00]

I haven't been able to prioritize writing a test for this, but here we go!

Anyone care to take another look?

[aelias_OOO_until_Jul13, 2015-01-12 19:56:32]

lgtm, thanks.

[Mathias Hällman, 2015-01-13 08:57:16]

The CQ bit was checked by mathiash@opera.com

[commit-bot: I haz the power, 2015-01-13 08:57:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/766753002/20001

[commit-bot: I haz the power, 2015-01-13 09:11:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-13 09:11:27]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/4...)

[Mathias Hällman, 2015-01-13 14:46:13]

The CQ bit was checked by mathiash@opera.com

[commit-bot: I haz the power, 2015-01-13 14:47:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/766753002/40001

[commit-bot: I haz the power, 2015-01-13 15:12:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-13 15:12:05]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/45953)

[Mathias Hällman, 2015-01-14 09:51:54]

The CQ bit was checked by mathiash@opera.com

[commit-bot: I haz the power, 2015-01-14 09:52:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/766753002/60001

[Mathias Hällman, 2015-01-14 10:04:23]

It seems the test decided to use an odd font on my Arch, so with PS3 I tried
tweaking some numbers to match what happens on Ubuntu, and it seems to have
worked. Then it failed on windows, however.
I'm committing and hoping it's ok that for PS4 I've tried setting font family
and size explicitly. Although it seems strange these defaults would be different
between the platforms. At least it worked on both my Arch and a coworker's
Ubuntu.. So that's something.

Anyway if this fails I have to assume it's because of the input fields being
native widgets, and I'm not sure how to deal with that in this test. Suggestions
would be welcome!

[commit-bot: I haz the power, 2015-01-14 10:54:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-14 10:54:59]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink ()

[Mathias Hällman, 2015-01-14 11:39:20]

The CQ bit was checked by mathiash@opera.com

[commit-bot: I haz the power, 2015-01-14 11:40:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/766753002/60001

[commit-bot: I haz the power, 2015-01-14 12:50:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-14 12:50:11]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink ()

[Mathias Hällman, 2015-01-14 12:55:12]

Ah, I thought integration failed because of the tree closing and reopening a
bunch of times.. I see now the test did fail on windows.

[Mathias Hällman, 2015-01-14 14:04:26]

The CQ bit was checked by mathiash@opera.com

[commit-bot: I haz the power, 2015-01-14 14:05:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/766753002/80001

[commit-bot: I haz the power, 2015-01-14 15:17:20]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188386