Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 766753002: Scroll text field when selecting text (Closed)

Created:
6 years ago by Mathias Hällman
Modified:
5 years, 11 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Scroll text field when selecting text BUG=437284 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188386

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
M Source/web/WebLocalFrameImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 2 3 4 1 chunk +20 lines, -0 lines 0 comments Download
A Source/web/tests/data/move_range_selection_extent_input_field.html View 1 4 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (10 generated)
Mathias Hällman
jochen, aelias, could either of you have a look at this? I basically added the ...
6 years ago (2014-11-27 15:12:07 UTC) #2
jochen (gone - plz use gerrit)
is it possible to add a test for this?
6 years ago (2014-11-28 13:08:34 UTC) #3
Mathias Hällman
On 2014/11/28 13:08:34, jochen (slow) wrote: > is it possible to add a test for ...
6 years ago (2014-11-28 13:54:53 UTC) #4
aelias_OOO_until_Jul13
I guess the test would need to load in some HTML with a textbox, select ...
6 years ago (2014-12-01 20:14:10 UTC) #5
Mathias Hällman
I haven't been able to prioritize writing a test for this, but here we go! ...
5 years, 11 months ago (2015-01-12 11:59:00 UTC) #6
aelias_OOO_until_Jul13
lgtm, thanks.
5 years, 11 months ago (2015-01-12 19:56:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/766753002/20001
5 years, 11 months ago (2015-01-13 08:57:55 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/41897)
5 years, 11 months ago (2015-01-13 09:11:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/766753002/40001
5 years, 11 months ago (2015-01-13 14:47:11 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/45953)
5 years, 11 months ago (2015-01-13 15:12:05 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/766753002/60001
5 years, 11 months ago (2015-01-14 09:52:08 UTC) #17
Mathias Hällman
It seems the test decided to use an odd font on my Arch, so with ...
5 years, 11 months ago (2015-01-14 10:04:23 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink ()
5 years, 11 months ago (2015-01-14 10:54:59 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/766753002/60001
5 years, 11 months ago (2015-01-14 11:40:20 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink ()
5 years, 11 months ago (2015-01-14 12:50:11 UTC) #24
Mathias Hällman
Ah, I thought integration failed because of the tree closing and reopening a bunch of ...
5 years, 11 months ago (2015-01-14 12:55:12 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/766753002/80001
5 years, 11 months ago (2015-01-14 14:05:13 UTC) #27
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 15:17:20 UTC) #28
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188386

Powered by Google App Engine
This is Rietveld 408576698