Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 766703002: MIPS: harmony-scoping: make assignment to 'const' a late error. (Closed)

Created:
6 years ago by balazs.kilvady
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

MIPS: harmony-scoping: make assignment to 'const' a late error. Port 6ac4de87a8b01500b066a3e401e921d2d84b42db Original commit message: Per TC39 Nov 2014 decision. This patch also changes behavior for "legacy const": assignments to sloppy const in strict mode is now also a type error. This fixes v8:2243 and also brings us in compliance with other engines re assignment to function names (see updated webkit test), but might have bigger implications. That change can easily be reverted by changing Variable::IsSignallingAssignmentToConst. BUG=v8:3713, v8:2243 LOG=N

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/mips/full-codegen-mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
balazs.kilvady
6 years ago (2014-11-27 10:07:53 UTC) #2
dusmil.imgtec
LGTM.
6 years ago (2014-11-27 10:50:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/766703002/1
6 years ago (2014-11-27 10:51:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-27 11:21:05 UTC) #6
Dmitry Lomov (no reviews)
6 years ago (2014-11-27 11:31:34 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698