Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 766673003: Make the ParserSync test faster (and re-enable it). (Closed)

Created:
6 years ago by marja
Modified:
6 years ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Make the ParserSync test faster (and re-enable it). Most of the run time came from testing with all possible flag combinations. None of the flags passed affect the test, and there are specialized tests for testing the features behind the flags; no need to slow down the generic test. With these changes, run time for debug build goes from 186 s to 0.5 s. In addition, fixed some missing commas between the test cases. R=svenpanne@chromium.org BUG=v8:3707 LOG=N Committed: https://chromium.googlesource.com/v8/v8/+/d3c217674f2bf306dd3df0e88cfd1d7051585b99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -18 lines) Patch
M test/cctest/test-parsing.cc View 5 chunks +5 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
marja
svenpanne, ptal
6 years ago (2014-12-02 11:41:59 UTC) #1
Sven Panne
lgtm
6 years ago (2014-12-02 12:04:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/766673003/1
6 years ago (2014-12-02 12:05:35 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1459)
6 years ago (2014-12-02 12:25:25 UTC) #6
marja
6 years ago (2014-12-02 13:23:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d3c217674f2bf306dd3df0e88cfd1d7051585b99 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698