cc: zero/one-copy based on shared memory on IOS uses GL_TEXTURE_2D, not GL_TEXTURE_RECTANGLE_ARB.

content/browser/renderer_host/render_process_host_impl.cc

Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index e683a1d5c25baca05e0e7108628f8f031ff46f3c..586f144069e8ac0ed440ae347549166a1cc1bbf2 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -1037,9 +1037,21 @@ static void AppendCompositorCommandLineFlags(base::CommandLine* command_line) {
     // The GPU service will always use the preferred type.
     gfx::GpuMemoryBufferType type = supported_types[0];
 
-    // Surface texture backed GPU memory buffers require TEXTURE_EXTERNAL_OES.
-    if (type == gfx::SURFACE_TEXTURE_BUFFER)
-      command_line->AppendSwitch(switches::kUseImageExternal);
+    switch (type) {
+      case gfx::SURFACE_TEXTURE_BUFFER:
+        // Surface texture backed GPU memory buffers require
+        // TEXTURE_EXTERNAL_OES.
+        command_line->AppendSwitchASCII(switches::kUseImageTextureTarget,
+                                        "external");

[piman, 2014/12/03 21:16:50]

nit: can you make "external" and "rectangle" a global constant (maybe in the
content_switches.cc/h files)? Since they're used in 2 places, that gives us a
compile-time guarantee against typos.

[dshwang, 2014/12/04 09:21:14]

That's good idea. Done.
in content_switches.cc
// Texture backed image requires GL_TEXTURE_RECTANGLE_ARB target.
const char kImageTextureRectangle[] = "image-texture-rectangle";

// Texture backed image requires GL_TEXTURE_EXTERNAL_OES target.
const char kImageTextureExternal[] = "image-texture-external";

+        break;
+      case gfx::IO_SURFACE_BUFFER:
+        // IOSurface backed images require GL_TEXTURE_RECTANGLE_ARB.
+        command_line->AppendSwitchASCII(switches::kUseImageTextureTarget,
+                                        "rectangle");
+        break;
+      default:
+        break;
+    }
   }
 
   // Appending disable-gpu-feature switches due to software rendering list.