Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 766663005: cc: zero/one-copy based on shared memory on IOS uses GL_TEXTURE_2D, not GL_TEXTURE_RECTANGLE_ARB. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Introduce switches::kUseImageIOSurface Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/trees/layer_tree_settings.h » ('j') | cc/trees/layer_tree_settings.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_impl.cc
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc
index ea30d8517395eed55d388bf2db0c7048ea3c3353..d572f0526c90d87e1d4c2d929c257d61cb90edae 100644
--- a/cc/trees/layer_tree_host_impl.cc
+++ b/cc/trees/layer_tree_host_impl.cc
@@ -2018,14 +2018,20 @@ void LayerTreeHostImpl::CreateResourceAndRasterWorkerPool(
if (GetRendererCapabilities().using_image) {
unsigned image_target = GL_TEXTURE_2D;
-#if defined(OS_MACOSX)
- // GL_TEXTURE_RECTANGLE_ARB target is required by IOSurface backed images.
- DCHECK(context_provider->ContextCapabilities().gpu.texture_rectangle);
- image_target = GL_TEXTURE_RECTANGLE_ARB;
-#endif
if (settings_.use_image_external) {
DCHECK(context_provider->ContextCapabilities().gpu.egl_image_external);
image_target = GL_TEXTURE_EXTERNAL_OES;
+#ifndef OS_ANDROID
+ NOTREACHED();
+#endif
+ }
+ if (settings_.use_image_io_surface) {
+ // GL_TEXTURE_RECTANGLE_ARB target is required by IOSurface backed images.
+ DCHECK(context_provider->ContextCapabilities().gpu.texture_rectangle);
+ image_target = GL_TEXTURE_RECTANGLE_ARB;
+#ifndef OS_MACOSX
+ NOTREACHED();
+#endif
}
if (settings_.use_zero_copy || IsSynchronousSingleThreaded()) {
« no previous file with comments | « no previous file | cc/trees/layer_tree_settings.h » ('j') | cc/trees/layer_tree_settings.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698