cc: zero/one-copy based on shared memory on IOS uses GL_TEXTURE_2D, not GL_TEXTURE_RECTANGLE_ARB.

content/renderer/render_thread_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_thread_impl.h"
 
 #include <algorithm>
 #include <limits>
 #include <map>
 #include <vector>
@@ skipping 84 matching lines @@
 #include "content/renderer/p2p/socket_dispatcher.h"
 #include "content/renderer/render_frame_proxy.h"
 #include "content/renderer/render_process_impl.h"
 #include "content/renderer/render_view_impl.h"
 #include "content/renderer/renderer_blink_platform_impl.h"
 #include "content/renderer/scheduler/renderer_scheduler.h"
 #include "content/renderer/service_worker/embedded_worker_context_message_filter.h"
 #include "content/renderer/service_worker/embedded_worker_dispatcher.h"
 #include "content/renderer/shared_worker/embedded_shared_worker_stub.h"
 #include "gin/public/debug.h"
+#include "gpu/GLES2/gl2extchromium.h"
+#include "gpu/command_buffer/common/gles2_cmd_utils.h"
 #include "ipc/ipc_channel_handle.h"
 #include "ipc/ipc_platform_file.h"
 #include "ipc/mojo/ipc_channel_mojo.h"
 #include "media/base/audio_hardware_config.h"
 #include "media/base/media.h"
 #include "media/filters/gpu_video_accelerator_factories.h"
 #include "mojo/common/common_type_converters.h"
 #include "net/base/net_errors.h"
 #include "net/base/net_util.h"
 #include "skia/ext/event_tracer_impl.h"
@@ skipping 399 matching lines @@
 
 #if defined(OS_MACOSX) || defined(OS_ANDROID)
   // TODO(danakj): If changing these also update NumberOfRendererRasterThreads
   // in compositor_util.cc. We should be using methods from compositor_util here
   // instead of inspecting flags.
   is_one_copy_enabled_ = command_line.HasSwitch(switches::kEnableOneCopy);
 #else
   is_one_copy_enabled_ = !command_line.HasSwitch(switches::kDisableOneCopy);
 #endif
 
-  use_image_external_ = command_line.HasSwitch(switches::kUseImageExternal);
+  use_image_texture_target_ = GL_TEXTURE_2D;
+  if (command_line.HasSwitch(switches::kUseImageTextureTarget)) {
+    std::string texture_target =
+        command_line.GetSwitchValueASCII(switches::kUseImageTextureTarget);
+    if (texture_target ==
+        gpu::gles2::GLES2Util::GetStringEnum(GL_TEXTURE_RECTANGLE_ARB)) {
+      use_image_texture_target_ = GL_TEXTURE_RECTANGLE_ARB;
+    } else if (texture_target ==
+               gpu::gles2::GLES2Util::GetStringEnum(GL_TEXTURE_EXTERNAL_OES)) {
+      use_image_texture_target_ = GL_TEXTURE_EXTERNAL_OES;
+    }

[reveman, 2014/12/04 20:10:38]

Current code is fine but you might want to consider something like this:

const unsigned targets[] = {
  GL_TEXTURE_RECTANGLE_ARB,
  GL_TEXTURE_EXTERNAL_OES
};
for (unsigned& target : targets) {
  if (target_string == gpu::gles2::GLES2Util::GetStringEnum(target))
    use_image_texture_target_ = target;
}

[dshwang, 2014/12/04 20:55:59]

nice code stub. I buy it :)
Done.

+  }
 
   if (command_line.HasSwitch(switches::kDisableLCDText)) {
     is_lcd_text_enabled_ = false;
   } else if (command_line.HasSwitch(switches::kEnableLCDText)) {
     is_lcd_text_enabled_ = true;
   } else {
 #if defined(OS_ANDROID)
     is_lcd_text_enabled_ = false;
 #else
     is_lcd_text_enabled_ = true;
@@ skipping 1080 matching lines @@
   hidden_widget_count_--;
 
   if (!GetContentClient()->renderer()->RunIdleHandlerWhenWidgetsHidden()) {
     return;
   }
 
   ScheduleIdleHandler(kLongIdleHandlerDelayMs);
 }
 
 }  // namespace content