Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 766633004: 'Paste as plain text' should not come when we does not have the plain text in clipboard. (Closed)

Created:
6 years ago by Deepak
Modified:
6 years ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

'Paste as plain text' should not come when we does not have the plain text in clipboard. "Paste as plain text" should not come when we don't have text in clipboard. "Paste as plain text" is handled so that when there is some text in clipboard then only it will get enabled. BUG=438099 Committed: https://crrev.com/d014c9b5c79c044d471634adb30edd597ebdaf67 Cr-Commit-Position: refs/heads/master@{#306630}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Deepak
PTAL at my changes. Thanks
6 years ago (2014-12-02 05:47:21 UTC) #2
Avi (use Gerrit)
https://codereview.chromium.org/766633004/diff/1/chrome/browser/renderer_context_menu/render_view_context_menu.cc File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://codereview.chromium.org/766633004/diff/1/chrome/browser/renderer_context_menu/render_view_context_menu.cc#newcode1210 chrome/browser/renderer_context_menu/render_view_context_menu.cc:1210: ui::Clipboard::GetForCurrentThread()->ReadText( Might you be able to use IsFormatAvailable?
6 years ago (2014-12-02 15:10:31 UTC) #3
Deepak
Thanks for review, Changes done. PTAL. https://codereview.chromium.org/766633004/diff/1/chrome/browser/renderer_context_menu/render_view_context_menu.cc File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://codereview.chromium.org/766633004/diff/1/chrome/browser/renderer_context_menu/render_view_context_menu.cc#newcode1210 chrome/browser/renderer_context_menu/render_view_context_menu.cc:1210: ui::Clipboard::GetForCurrentThread()->ReadText( On 2014/12/02 ...
6 years ago (2014-12-03 04:18:21 UTC) #4
Avi (use Gerrit)
LGTM.
6 years ago (2014-12-03 16:23:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/766633004/20001
6 years ago (2014-12-03 17:25:32 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-03 18:22:20 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-03 18:23:29 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d014c9b5c79c044d471634adb30edd597ebdaf67
Cr-Commit-Position: refs/heads/master@{#306630}

Powered by Google App Engine
This is Rietveld 408576698