Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 766403002: Move test_service implementation to //services (Closed)

Created:
6 years ago by jamesr
Modified:
6 years ago
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -805 lines) Patch
M mojo/services/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
D mojo/services/test_service/BUILD.gn View 1 chunk +0 lines, -63 lines 0 comments Download
D mojo/services/test_service/test_request_tracker.mojom View 1 chunk +0 lines, -41 lines 0 comments Download
D mojo/services/test_service/test_request_tracker_application.h View 1 chunk +0 lines, -49 lines 0 comments Download
D mojo/services/test_service/test_request_tracker_application.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D mojo/services/test_service/test_request_tracker_client_impl.h View 1 chunk +0 lines, -42 lines 0 comments Download
D mojo/services/test_service/test_request_tracker_client_impl.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D mojo/services/test_service/test_request_tracker_impl.h View 1 chunk +0 lines, -63 lines 0 comments Download
D mojo/services/test_service/test_request_tracker_impl.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D mojo/services/test_service/test_service.mojom View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/services/test_service/test_service_application.h View 1 chunk +0 lines, -49 lines 0 comments Download
D mojo/services/test_service/test_service_application.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D mojo/services/test_service/test_service_impl.h View 1 chunk +0 lines, -45 lines 0 comments Download
D mojo/services/test_service/test_service_impl.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D mojo/services/test_service/test_time_service_impl.h View 1 chunk +0 lines, -43 lines 0 comments Download
D mojo/services/test_service/test_time_service_impl.cc View 1 chunk +0 lines, -44 lines 0 comments Download
M mojo/shell/BUILD.gn View 1 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/shell/shell_test_base_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A + services/test_service/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/test_service/test_request_tracker.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/test_service/test_request_tracker_application.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + services/test_service/test_request_tracker_application.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + services/test_service/test_request_tracker_client_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + services/test_service/test_request_tracker_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/test_service/test_request_tracker_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + services/test_service/test_request_tracker_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/test_service/test_service.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/test_service/test_service_application.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/test_service/test_service_application.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/test_service/test_service_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + services/test_service/test_service_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + services/test_service/test_time_service_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + services/test_service/test_time_service_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jamesr
6 years ago (2014-12-02 02:27:12 UTC) #1
jamesr
6 years ago (2014-12-02 21:17:48 UTC) #3
Ben Goodger (Google)
lgtm
6 years ago (2014-12-02 21:50:30 UTC) #5
jamesr
6 years ago (2014-12-03 22:46:46 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
63b637af00ce02363a4d1a6108b1bd8b3e1ac5a2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698