Remove IO allowed assert in GetTempDir()

Remove IO allowed assert in GetTempDir()

GetTempDir() does not do file IO, therefore it can be used from other threads
to create file paths. No other platform implementation has that assert.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239428

[jam, 2013-11-20 04:43:10]

lgtm

[commit-bot: I haz the power, 2013-11-20 12:04:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaoe@opera.com/76633002/1

[commit-bot: I haz the power, 2013-11-20 12:18:38]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[João Eiras, 2013-12-06 13:56:22]

Hi again!

Could an owner please lgtm this review ?

Thank you in advance.

[brettw, 2013-12-06 20:53:46]

lgtm

[commit-bot: I haz the power, 2013-12-07 19:35:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaoe@opera.com/76633002/1

[commit-bot: I haz the power, 2013-12-07 19:35:06]

Failed to apply patch for base/file_util_win.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file base/file_util_win.cc
  Hunk #1 FAILED at 224.
  1 out of 1 hunk FAILED -- saving rejects to file base/file_util_win.cc.rej

Patch:       base/file_util_win.cc
Index: base/file_util_win.cc
diff --git a/base/file_util_win.cc b/base/file_util_win.cc
index
86c5eea9678fe19d6abbeab22ee027c13eddd2c5..fff62552442e3b3efc32739d362a17a765088be9
100644
--- a/base/file_util_win.cc
+++ b/base/file_util_win.cc
@@ -224,8 +224,6 @@ using base::FilePath;
 using base::kFileShareAll;
 
 bool GetTempDir(FilePath* path) {
-  base::ThreadRestrictions::AssertIOAllowed();
-
   wchar_t temp_path[MAX_PATH + 1];
   DWORD path_len = ::GetTempPath(MAX_PATH, temp_path);
   if (path_len >= MAX_PATH || path_len <= 0)

[commit-bot: I haz the power, 2013-12-07 19:35:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaoe@opera.com/76633002/1

[commit-bot: I haz the power, 2013-12-07 19:35:57]

Failed to apply patch for base/file_util_win.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file base/file_util_win.cc
  Hunk #1 FAILED at 224.
  1 out of 1 hunk FAILED -- saving rejects to file base/file_util_win.cc.rej

Patch:       base/file_util_win.cc
Index: base/file_util_win.cc
diff --git a/base/file_util_win.cc b/base/file_util_win.cc
index
86c5eea9678fe19d6abbeab22ee027c13eddd2c5..fff62552442e3b3efc32739d362a17a765088be9
100644
--- a/base/file_util_win.cc
+++ b/base/file_util_win.cc
@@ -224,8 +224,6 @@ using base::FilePath;
 using base::kFileShareAll;
 
 bool GetTempDir(FilePath* path) {
-  base::ThreadRestrictions::AssertIOAllowed();
-
   wchar_t temp_path[MAX_PATH + 1];
   DWORD path_len = ::GetTempPath(MAX_PATH, temp_path);
   if (path_len >= MAX_PATH || path_len <= 0)

[commit-bot: I haz the power, 2013-12-09 01:16:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaoe@opera.com/76633002/120001

[commit-bot: I haz the power, 2013-12-09 03:37:25]

Change committed as 239428