Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: pkg/analysis_server/test/integration/analysis/package_root_test.dart

Issue 766323002: Compressed/optimized navigation notification. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updates for review comments. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/integration/analysis/package_root_test.dart
diff --git a/pkg/analysis_server/test/integration/analysis/package_root_test.dart b/pkg/analysis_server/test/integration/analysis/package_root_test.dart
index d2a7800eac46746cf1e5c22c20e3f4fdd3c487a4..c10141741830795e79ada144756adffca864655f 100644
--- a/pkg/analysis_server/test/integration/analysis/package_root_test.dart
+++ b/pkg/analysis_server/test/integration/analysis/package_root_test.dart
@@ -43,9 +43,13 @@ f() {}
AnalysisService.NAVIGATION: [mainPath]
});
List<NavigationRegion> navigationRegions;
+ List<NavigationTarget> navigationTargets;
+ List<String> navigationTargetFiles;
onAnalysisNavigation.listen((AnalysisNavigationParams params) {
expect(params.file, equals(mainPath));
navigationRegions = params.regions;
+ navigationTargets = params.targets;
+ navigationTargetFiles = params.files;
});
sendAnalysisSetAnalysisRoots([projPath], [], packageRoots: {
projPath: packagesPath
@@ -60,8 +64,10 @@ f() {}
if (navigationSource == 'f') {
found = true;
expect(region.targets, hasLength(1));
- Location location = region.targets[0].location;
- expect(location.file, equals(normalizedFooBarPath));
+ int navigationTargetIndex = region.targets[0];
+ NavigationTarget navigationTarget = navigationTargets[navigationTargetIndex];
+ String navigationFile = navigationTargetFiles[navigationTarget.fileIndex];
+ expect(navigationFile, equals(normalizedFooBarPath));
}
}
expect(found, isTrue);

Powered by Google App Engine
This is Rietveld 408576698