pkg/analysis_server/lib/src/operation/operation_analysis.dart - Issue 766323002: Compressed/optimized navigation notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/operation/operation_analysis.dart

Issue 766323002: Compressed/optimized navigation notification. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updates for review comments. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analysis_server/lib/src/operation/operation_analysis.dart

diff --git a/pkg/analysis_server/lib/src/operation/operation_analysis.dart b/pkg/analysis_server/lib/src/operation/operation_analysis.dart

index 6ce6fbddaccc9a4f6bf31e4c6850486183add61d..a642da2c3e99050a1f020ef938386b42cad09bd9 100644

--- a/pkg/analysis_server/lib/src/operation/operation_analysis.dart

+++ b/pkg/analysis_server/lib/src/operation/operation_analysis.dart

@@ -38,8 +38,13 @@ void sendAnalysisNotificationHighlights(AnalysisServer server, String file,

void sendAnalysisNotificationNavigation(AnalysisServer server, String file,

CompilationUnit dartUnit) {

- var regions = new DartUnitNavigationComputer(dartUnit).compute();

- var params = new protocol.AnalysisNavigationParams(file, regions);

+ var computer = new DartUnitNavigationComputer(dartUnit);

+ computer.compute();

+ var params = new protocol.AnalysisNavigationParams(

+ file,

+ computer.regions,

+ computer.targets,

+ computer.files);

server.sendNotification(params.toNotification());

}