editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartNavigationRegionHyperlink_NEW.java - Issue 766323002: Compressed/optimized navigation notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartNavigationRegionHyperlink_NEW.java

Issue 766323002: Compressed/optimized navigation notification. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updates for review comments. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/actions/RenameDartElementAction_NEW.java ('k') | pkg/analysis_server/doc/api.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartNavigationRegionHyperlink_NEW.java

diff --git a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartNavigationRegionHyperlink_NEW.java b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartNavigationRegionHyperlink_NEW.java

index 5a2ad3e355631666c14e08b66b64ae9244b1bb03..137958d799cac15218fc7160d2558f83665bcce8 100644

--- a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartNavigationRegionHyperlink_NEW.java

+++ b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartNavigationRegionHyperlink_NEW.java

@@ -15,8 +15,8 @@ package com.google.dart.tools.ui.internal.text.editor;

import com.google.dart.engine.utilities.instrumentation.Instrumentation;

import com.google.dart.engine.utilities.instrumentation.InstrumentationBuilder;

-import com.google.dart.server.generated.types.Element;

import com.google.dart.server.generated.types.NavigationRegion;

+import com.google.dart.server.generated.types.NavigationTarget;

import com.google.dart.tools.ui.DartUI;

import org.eclipse.core.resources.IFile;

@@ -59,7 +59,7 @@ public class DartNavigationRegionHyperlink_NEW implements IHyperlink {

public void open() {

InstrumentationBuilder instrumentation = Instrumentation.builder(this.getClass());

try {

- List<Element> targets = region.getTargets();

+ List<NavigationTarget> targets = region.getTargetObjects();

if (targets.size() != 0) {

DartUI.openInEditor(targets.get(0), true);

}