editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/OpenAction_OLD.java - Issue 766323002: Compressed/optimized navigation notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/OpenAction_OLD.java

Issue 766323002: Compressed/optimized navigation notification. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updates for review comments. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/OpenAction_NEW.java ('k') | editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/OpenTypeHierarchyAction_NEW.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/OpenAction_OLD.java

diff --git a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/OpenAction_OLD.java b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/OpenAction_OLD.java

index 92997fcdfe507bfe806c8cacf7f337b84bcaa9dc..b0ef657ed140bf787c398fef2467f0d25ed56779 100644

--- a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/OpenAction_OLD.java

+++ b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/OpenAction_OLD.java

@@ -20,10 +20,8 @@ import com.google.dart.engine.element.Element;

import com.google.dart.engine.element.FieldFormalParameterElement;

import com.google.dart.engine.element.polymer.PolymerTagDartElement;

import com.google.dart.engine.element.polymer.PolymerTagHtmlElement;

-import com.google.dart.engine.services.assist.AssistContext;

import com.google.dart.tools.ui.DartUI;

import com.google.dart.tools.ui.instrumentation.UIInstrumentationBuilder;

-import com.google.dart.tools.ui.internal.actions.NewSelectionConverter;

import com.google.dart.tools.ui.internal.text.DartHelpContextIds;

import com.google.dart.tools.ui.internal.text.editor.DartEditor;

import com.google.dart.tools.ui.internal.text.editor.DartSelection;

@@ -40,20 +38,6 @@ import org.eclipse.ui.texteditor.IEditorStatusLine;

public class OpenAction_OLD extends AbstractDartSelectionAction_OLD {

/**

- * Returns navigation targets for the given context, may be empty, but not {@code null}.

- */

- public static com.google.dart.server.generated.types.Element[] getNavigationTargets(

- DartSelection selection) {

- int offset = selection.getOffset();

- AssistContext assistContext = selection.getContext();

- if (assistContext != null) {

- String file = assistContext.getFile();

- return NewSelectionConverter.getNavigationTargets(file, offset);

- }

- return com.google.dart.server.generated.types.Element.EMPTY_ARRAY;

- }

- /**

* @return {@code true} if given {@link DartSelection} looks valid and we can try to open it.

private static boolean isValidSelection(DartSelection selection) {