editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/ConvertMethodToGetterAction_NEW.java - Issue 766323002: Compressed/optimized navigation notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/ConvertMethodToGetterAction_NEW.java

Issue 766323002: Compressed/optimized navigation notification. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updates for review comments. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/ConvertGetterToMethodAction_NEW.java ('k') | editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/InlineLocalAction_NEW.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/ConvertMethodToGetterAction_NEW.java

diff --git a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/ConvertMethodToGetterAction_NEW.java b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/ConvertMethodToGetterAction_NEW.java

index b68ab08552db7457411facc77ba245e653fefa87..5fe09cd731e17a2976567c115cac3dd6b23a6559 100644

--- a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/ConvertMethodToGetterAction_NEW.java

+++ b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/ConvertMethodToGetterAction_NEW.java

@@ -13,9 +13,9 @@

package com.google.dart.tools.ui.actions;

-import com.google.dart.server.generated.types.Element;

import com.google.dart.server.generated.types.ElementKind;

import com.google.dart.server.generated.types.NavigationRegion;

+import com.google.dart.server.generated.types.NavigationTarget;

import com.google.dart.tools.core.DartCore;

import com.google.dart.tools.core.analysis.model.AnalysisServerNavigationListener;

import com.google.dart.tools.ui.internal.actions.NewSelectionConverter;

@@ -86,10 +86,10 @@ public class ConvertMethodToGetterAction_NEW extends AbstractRefactoringAction_N

private void updateSelectedElement() {

setEnabled(false);

- Element[] elements = NewSelectionConverter.getNavigationTargets(file, selectionOffset);

- if (elements.length != 0) {

- Element element = elements[0];

- String kind = element.getKind();

+ NavigationTarget[] targets = NewSelectionConverter.getNavigationTargets(file, selectionOffset);

+ if (targets.length != 0) {

+ NavigationTarget target = targets[0];

+ String kind = target.getKind();

setEnabled(kind.equals(ElementKind.FUNCTION) || kind.equals(ElementKind.METHOD));

}