Compressed/optimized navigation notification.

pkg/analysis_server/tool/spec/codegen_java_types.dart

Index: pkg/analysis_server/tool/spec/codegen_java_types.dart
diff --git a/pkg/analysis_server/tool/spec/codegen_java_types.dart b/pkg/analysis_server/tool/spec/codegen_java_types.dart
index e459087e6d9705bd29fae76c0c13e6cf90e31252..5f2b279cd058ddde8ae17a2126adf31ac729fcde 100644
--- a/pkg/analysis_server/tool/spec/codegen_java_types.dart
+++ b/pkg/analysis_server/tool/spec/codegen_java_types.dart
@@ -355,6 +355,16 @@ class CodegenJavaType extends CodegenJavaVisitor {
           writeln('private List<Outline> children;');
         });
       }
+      if (className == 'NavigationRegion') {
+        privateField(javaName('targets'), () {
+          writeln('private List<NavigationTarget> allTargets;');
+        });
+      }
+      if (className == 'NavigationTarget') {
+        privateField(javaName('targetFiles'), () {
+          writeln('private String[] allTargetFiles;');
+        });
+      }
 
       //
       // constructor
@@ -442,6 +452,37 @@ class CodegenJavaType extends CodegenJavaVisitor {
         }
       }
 
+      if (className == 'NavigationRegion') {
+        publicMethod('setAllTargets', () {
+          writeln('public void setAllTargets(List<NavigationTarget> allTargets) {');
+          writeln('  this.allTargets = allTargets;');

[Paul Berry, 2014/12/01 21:50:37]

I would feel more comfortable if, instead of storing all targets in the data
structure and deferring the lookup until getTargets(), we simply did the lookup
immediately and stored just the targets we need.  That way each NavigationRegion
object would only be holding references to a small number of targets.  That
should avoid memory bloat when we start implementing paged notifications.

[scheglov, 2014/12/01 22:20:32]

Good idea.
Thank you.
Done.

+          writeln('}');
+        });
+        publicMethod('getTargets', () {
+          writeln('public List<NavigationTarget> getTargets() {');
+          writeln('  List<NavigationTarget> targets = new ArrayList<NavigationTarget>();');
+          writeln('  for (int i = 0; i < targetIndexes.length; i++) {');
+          writeln('    int targetIndex = targetIndexes[i];');
+          writeln('    NavigationTarget target = allTargets.get(targetIndex);');
+          writeln('    targets.add(target);');
+          writeln('  }');
+          writeln('  return targets;');
+          writeln('}');
+        });
+      }
+      if (className == 'NavigationTarget') {
+        publicMethod('setAllTargetFiles', () {
+          writeln('public void setAllTargetFiles(String[] allTargetFiles) {');
+          writeln('  this.allTargetFiles = allTargetFiles;');

[Paul Berry, 2014/12/01 21:50:37]

Similar situation here.

+          writeln('}');
+        });
+        publicMethod('getFile', () {
+          writeln('public String getFile() {');
+          writeln('  return allTargetFiles[fileIndex];');
+          writeln('}');
+        });
+      }
+
       //
       // fromJson(JsonObject) factory constructor, example:
 //      public JsonObject toJson(JsonObject jsonObject) {