A private API for the cryptotoken component extension.

A private API for the cryptotoken component extension.

Allows the extension to display an infobar to collect explicit user consent
before registering a key.

BUG=426358
Committed: https://crrev.com/761734c77f75ed82ccadd79831acc64f77762510
Cr-Commit-Position: refs/heads/master@{#308199}

[not at google - send to devlin, 2014-12-05 17:59:53]

kalman@chromium.org changed reviewers:
+ kalman@chromium.org

[not at google - send to devlin, 2014-12-05 17:59:54]

https://codereview.chromium.org/766303003/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/cryptotoken_private.idl (right):

https://codereview.chromium.org/766303003/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/cryptotoken_private.idl:16: UNKNOWN
I would call this something other than UNKNOWN, because you know it wasn't
allowed, and you know it wasn't denied. A known unknown, if you will.

https://codereview.chromium.org/766303003/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/cryptotoken_private.idl:31: DOMString
securityOrigin,
and I would make this an object, for backwards compatibility.

[Arnar Birgisson, 2014-12-05 18:28:03]

https://codereview.chromium.org/766303003/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/cryptotoken_private.idl (right):

https://codereview.chromium.org/766303003/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/cryptotoken_private.idl:16: UNKNOWN
On 2014/12/05 17:59:54, kalman wrote:
> I would call this something other than UNKNOWN, because you know it wasn't
> allowed, and you know it wasn't denied. A known unknown, if you will.

Good point. Does "DISMISSED" capture it?

[not at google - send to devlin, 2014-12-05 19:07:56]

lgtm

https://codereview.chromium.org/766303003/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/cryptotoken_private.idl (right):

https://codereview.chromium.org/766303003/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/cryptotoken_private.idl:7: [nodoc] namespace
cryptotokenPrivate {
nodoc not necessary, so long as you don't add an HTML page for it it won't be
documented.

https://codereview.chromium.org/766303003/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/cryptotoken_private.idl:16: UNKNOWN
On 2014/12/05 18:28:02, Arnar Birgisson wrote:
> On 2014/12/05 17:59:54, kalman wrote:
> > I would call this something other than UNKNOWN, because you know it wasn't
> > allowed, and you know it wasn't denied. A known unknown, if you will.
> 
> Good point. Does "DISMISSED" capture it?

It does, SGTM.

https://codereview.chromium.org/766303003/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/cryptotoken_private.idl:22: // Explicitly gathers
approval from the user that an origin in a tab is allowed
80 chars?

[juanlang (chromium.org), 2014-12-10 01:39:04]

juanlang@chromium.org changed reviewers:
+ juanlang@chromium.org

[juanlang (chromium.org), 2014-12-10 01:39:05]

https://codereview.chromium.org/766303003/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/cryptotoken_private.idl (right):

https://codereview.chromium.org/766303003/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/cryptotoken_private.idl:11: // User expclitly
allowed
Nit: s/expclitly/explicitly/

[Arnar Birgisson, 2014-12-11 20:12:52]

arnarb@chromium.org changed reviewers:
+ reillyg@chromium.org

[Arnar Birgisson, 2014-12-11 20:12:53]

Added an implementation, please take another look.

https://codereview.chromium.org/766303003/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/cryptotoken_private.idl (right):

https://codereview.chromium.org/766303003/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/cryptotoken_private.idl:7: [nodoc] namespace
cryptotokenPrivate {
On 2014/12/05 19:07:56, kalman wrote:
> nodoc not necessary, so long as you don't add an HTML page for it it won't be
> documented.

Done.

https://codereview.chromium.org/766303003/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/cryptotoken_private.idl:16: UNKNOWN
On 2014/12/05 19:07:56, kalman wrote:
> On 2014/12/05 18:28:02, Arnar Birgisson wrote:
> > On 2014/12/05 17:59:54, kalman wrote:
> > > I would call this something other than UNKNOWN, because you know it wasn't
> > > allowed, and you know it wasn't denied. A known unknown, if you will.
> > 
> > Good point. Does "DISMISSED" capture it?
> 
> It does, SGTM.

Done.

https://codereview.chromium.org/766303003/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/cryptotoken_private.idl:22: // Explicitly gathers
approval from the user that an origin in a tab is allowed
On 2014/12/05 19:07:55, kalman wrote:
> 80 chars?

Done.

https://codereview.chromium.org/766303003/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/cryptotoken_private.idl:31: DOMString
securityOrigin,
On 2014/12/05 17:59:54, kalman wrote:
> and I would make this an object, for backwards compatibility.

Backward compatibility with what? Should only be called from cryptotoken which
will send a string. Other private APIs do the same, e.g.
chrome/common/extensions/api/webrtc_audio_private.idl

[Reilly Grant (use Gerrit), 2014-12-11 23:50:06]

lgtm (but kalman@ will have to approve)

[not at google - send to devlin, 2014-12-11 23:53:09]

I approve.

[Arnar Birgisson, 2014-12-12 01:03:47]

Owners, please review the following parts:

oshima: chrome/app/theme

xiyuan: cryptotoken manifest (I'll submit a cryptotoken OWNERS file soon)

asvitkine: Histograms

Thanks!

TBR=oshima,xiyuan,asvitkine

[Arnar Birgisson, 2014-12-12 01:10:42]

Rebased and hopefully added owner TBRs correctly this time.

[Arnar Birgisson, 2014-12-12 01:14:18]

arnarb@chromium.org changed reviewers:
+ asvitkine@chromium.org, oshima@chromium.org, xiyuan@chromium.org

[Arnar Birgisson, 2014-12-12 01:15:15]

Owners, please review the following parts:

oshima: chrome/app/theme

xiyuan: cryptotoken manifest (I'll submit a cryptotoken OWNERS file soon)

asvitkine: Histograms

(others, sorry for the noise)

[xiyuan, 2014-12-12 01:28:07]

chrome/browser/resources/cryptotoken/manifest.json LGTM

[Alexei Svitkine (slow), 2014-12-12 16:21:33]

histograms lgtm

[oshima, 2014-12-12 19:30:22]

https://codereview.chromium.org/766303003/diff/80001/chrome/app/theme/theme_r...
File chrome/app/theme/theme_resources.grd (right):

https://codereview.chromium.org/766303003/diff/80001/chrome/app/theme/theme_r...
chrome/app/theme/theme_resources.grd:446: <structure type="chrome_scaled_image"
name="IDR_INFOBAR_CRYPTOTOKEN" file="common/infobar_cryptotoken.png" />
please sort

[Arnar Birgisson, 2014-12-12 19:37:13]

Correct sort + rebase.

https://codereview.chromium.org/766303003/diff/80001/chrome/app/theme/theme_r...
File chrome/app/theme/theme_resources.grd (right):

https://codereview.chromium.org/766303003/diff/80001/chrome/app/theme/theme_r...
chrome/app/theme/theme_resources.grd:446: <structure type="chrome_scaled_image"
name="IDR_INFOBAR_CRYPTOTOKEN" file="common/infobar_cryptotoken.png" />
On 2014/12/12 19:30:21, oshima wrote:
> please sort

Done.

[oshima, 2014-12-12 19:49:43]

c/a/theme lgtm

[Arnar Birgisson, 2014-12-12 21:32:00]

arnarb@chromium.org changed reviewers:
- juanlang@chromium.org

[Arnar Birgisson, 2014-12-12 21:40:16]

The CQ bit was checked by arnarb@chromium.org

[commit-bot: I haz the power, 2014-12-12 21:40:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/766303003/100001

[Arnar Birgisson, 2014-12-12 22:16:54]

The CQ bit was unchecked by arnarb@chromium.org

[Arnar Birgisson, 2014-12-12 22:26:51]

The CQ bit was checked by arnarb@chromium.org

[commit-bot: I haz the power, 2014-12-12 22:28:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/766303003/120001

[commit-bot: I haz the power, 2014-12-13 00:07:30]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2014-12-13 00:08:28]

Patchset 7 (id:??) landed as
https://crrev.com/761734c77f75ed82ccadd79831acc64f77762510
Cr-Commit-Position: refs/heads/master@{#308199}