Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Side by Side Diff: sky/engine/core/rendering/RenderView.cpp

Issue 766303002: Remove some dead paint flags. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderLayer.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 return false; 245 return false;
246 246
247 return true; 247 return true;
248 } 248 }
249 249
250 void RenderView::paintBoxDecorationBackground(PaintInfo& paintInfo, const Layout Point&) 250 void RenderView::paintBoxDecorationBackground(PaintInfo& paintInfo, const Layout Point&)
251 { 251 {
252 if (!view()) 252 if (!view())
253 return; 253 return;
254 254
255 if (paintInfo.skipRootBackground())
256 return;
257
258 bool shouldPaintBackground = true; 255 bool shouldPaintBackground = true;
259 Node* documentElement = document().documentElement(); 256 Node* documentElement = document().documentElement();
260 if (RenderBox* rootBox = documentElement ? toRenderBox(documentElement->rend erer()) : 0) 257 if (RenderBox* rootBox = documentElement ? toRenderBox(documentElement->rend erer()) : 0)
261 shouldPaintBackground = !rendererObscuresBackground(rootBox); 258 shouldPaintBackground = !rendererObscuresBackground(rootBox);
262 259
263 // If painting will entirely fill the view, no need to fill the background. 260 // If painting will entirely fill the view, no need to fill the background.
264 if (!shouldPaintBackground) 261 if (!shouldPaintBackground)
265 return; 262 return;
266 263
267 // This code typically only executes if the root element's visibility has be en set to hidden, 264 // This code typically only executes if the root element's visibility has be en set to hidden,
(...skipping 441 matching lines...) Expand 10 before | Expand all | Expand 10 after
709 m_iframes.remove(iframe); 706 m_iframes.remove(iframe);
710 } 707 }
711 708
712 void RenderView::updateIFramesAfterLayout() 709 void RenderView::updateIFramesAfterLayout()
713 { 710 {
714 for (auto& iframe: m_iframes) 711 for (auto& iframe: m_iframes)
715 iframe->updateWidgetBounds(); 712 iframe->updateWidgetBounds();
716 } 713 }
717 714
718 } // namespace blink 715 } // namespace blink
OLDNEW
« no previous file with comments | « sky/engine/core/rendering/RenderLayer.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698