Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 766273003: nacl-clang: use gas by default instead of the LLVM assembler (Closed)

Created:
6 years ago by Derek Schuff
Modified:
6 years ago
CC:
native-client-reviews_googlegroups.com
Project:
nacl
Visibility:
Public.

Description

nacl-clang: use gas by default instead of the LLVM assembler Update COMPONENT_REVISIONS to bring in the following LLVM changes: e2a83b3 (dschuff@chromium.org): Remove nacltlsaddr32 from assembly layer 74eb265 (dschuff@chromium.org): Use "." instead of label difference for GOT address calculations with gas and the following clang change: 0de7964 (dschuff@chromium.org): Use gas (non-integrated assembler) by default for nacl-clang Also remove the SCons hack that disabled the integrated assembler when building .S files R=jvoung@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=3966 BUG= https://code.google.com/p/nativeclient/issues/detail?id=3946 Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=14155

Patch Set 1 #

Patch Set 2 : add clang #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M pnacl/COMPONENT_REVISIONS View 1 1 chunk +2 lines, -2 lines 0 comments Download
M site_scons/site_tools/naclsdk.py View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Derek Schuff
6 years ago (2014-12-02 00:34:03 UTC) #1
jvoung (off chromium)
LGTM Can some of scons files that check nacl_clang and bail be changed? https://codereview.chromium.org/639113003/diff/1060001/tests/stubout_mode/nacl.scons https://codereview.chromium.org/639113003/diff/1060001/tests/exception_test/nacl.scons ...
6 years ago (2014-12-02 01:59:38 UTC) #2
Derek Schuff
On 2014/12/02 01:59:38, jvoung wrote: > LGTM > > Can some of scons files that ...
6 years ago (2014-12-02 16:43:12 UTC) #3
Derek Schuff
6 years ago (2014-12-02 16:44:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 14155 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698