chrome/browser/ui/views/toolbar/browser_actions_container.cc - Issue 766263003: [Extension Toolbar] Refactor and finish pop out logic for actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/browser_actions_container.cc

Issue 766263003: [Extension Toolbar] Refactor and finish pop out logic for actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sky's + OWNERS Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/toolbar/toolbar_actions_bar.cc ('K') | « chrome/browser/ui/views/toolbar/OWNERS ('k') | chrome/browser/ui/views/toolbar/test_toolbar_actions_bar_helper_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/toolbar/browser_actions_container.cc

diff --git a/chrome/browser/ui/views/toolbar/browser_actions_container.cc b/chrome/browser/ui/views/toolbar/browser_actions_container.cc

index f2e2ac00ac7c8c66324da8467c15a0f98139ada2..036168cfdbeec5df330b0c7728d63b8e29f0b503 100644

--- a/chrome/browser/ui/views/toolbar/browser_actions_container.cc

+++ b/chrome/browser/ui/views/toolbar/browser_actions_container.cc

@@ -66,9 +66,11 @@ BrowserActionsContainer::DropPosition::DropPosition(

BrowserActionsContainer::BrowserActionsContainer(

Browser* browser,

BrowserActionsContainer* main_container)

- : toolbar_actions_bar_(new ToolbarActionsBar(this,

- browser,

- main_container != nullptr)),

+ : toolbar_actions_bar_(new ToolbarActionsBar(

+ this,

+ browser,

+ main_container ?

+ main_container->toolbar_actions_bar_.get() : nullptr)),

browser_(browser),

main_container_(main_container),

popup_owner_(NULL),