Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: chrome/browser/ui/views/toolbar/test_toolbar_actions_bar_helper_views.cc

Issue 766263003: [Extension Toolbar] Refactor and finish pop out logic for actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sky's + OWNERS Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/toolbar/test_toolbar_actions_bar_helper.h" 5 #include "chrome/browser/ui/toolbar/test_toolbar_actions_bar_helper.h"
6 6
7 #include "chrome/browser/ui/views/toolbar/browser_actions_container.h" 7 #include "chrome/browser/ui/views/toolbar/browser_actions_container.h"
8 #include "ui/views/view.h" 8 #include "ui/views/view.h"
9 9
10 namespace { 10 namespace {
11 11
12 // The views-specific implementation of the TestToolbarActionsBarHelper, which 12 // The views-specific implementation of the TestToolbarActionsBarHelper, which
13 // creates and owns a BrowserActionsContainer. 13 // creates and owns a BrowserActionsContainer.
14 class TestToolbarActionsBarHelperViews : public TestToolbarActionsBarHelper { 14 class TestToolbarActionsBarHelperViews : public TestToolbarActionsBarHelper {
15 public: 15 public:
16 explicit TestToolbarActionsBarHelperViews(Browser* browser); 16 TestToolbarActionsBarHelperViews(Browser* browser,
17 TestToolbarActionsBarHelperViews* main_bar);
17 ~TestToolbarActionsBarHelperViews() override; 18 ~TestToolbarActionsBarHelperViews() override;
18 19
19 private: 20 private:
20 // TestToolbarActionsBarHelper: 21 // TestToolbarActionsBarHelper:
21 ToolbarActionsBar* GetToolbarActionsBar() override; 22 ToolbarActionsBar* GetToolbarActionsBar() override;
22 23
23 // The parent of the BrowserActionsContainer, which directly owns the 24 // The parent of the BrowserActionsContainer, which directly owns the
24 // container as part of the views hierarchy. 25 // container as part of the views hierarchy.
25 views::View container_parent_; 26 views::View container_parent_;
26 27
27 // The created BrowserActionsContainer. Owned by |container_parent_|. 28 // The created BrowserActionsContainer. Owned by |container_parent_|.
28 BrowserActionsContainer* browser_actions_container_; 29 BrowserActionsContainer* browser_actions_container_;
29 30
30 DISALLOW_COPY_AND_ASSIGN(TestToolbarActionsBarHelperViews); 31 DISALLOW_COPY_AND_ASSIGN(TestToolbarActionsBarHelperViews);
31 }; 32 };
32 33
33 TestToolbarActionsBarHelperViews::TestToolbarActionsBarHelperViews( 34 TestToolbarActionsBarHelperViews::TestToolbarActionsBarHelperViews(
34 Browser* browser) 35 Browser* browser,
36 TestToolbarActionsBarHelperViews* main_bar)
35 : browser_actions_container_( 37 : browser_actions_container_(
36 new BrowserActionsContainer(browser, nullptr)) { 38 new BrowserActionsContainer(
39 browser,
40 main_bar ? main_bar->browser_actions_container_ : nullptr)) {
37 // The BrowserActionsContainer expects to have a parent (and be added to the 41 // The BrowserActionsContainer expects to have a parent (and be added to the
38 // view hierarchy), so wrap it in a shell view. 42 // view hierarchy), so wrap it in a shell view.
39 container_parent_.set_owned_by_client(); 43 container_parent_.set_owned_by_client();
40 container_parent_.AddChildView(browser_actions_container_); 44 container_parent_.AddChildView(browser_actions_container_);
41 } 45 }
42 46
43 TestToolbarActionsBarHelperViews::~TestToolbarActionsBarHelperViews() {} 47 TestToolbarActionsBarHelperViews::~TestToolbarActionsBarHelperViews() {}
44 48
45 ToolbarActionsBar* TestToolbarActionsBarHelperViews::GetToolbarActionsBar() { 49 ToolbarActionsBar* TestToolbarActionsBarHelperViews::GetToolbarActionsBar() {
46 return browser_actions_container_->toolbar_actions_bar(); 50 return browser_actions_container_->toolbar_actions_bar();
47 } 51 }
48 52
49 } // namespace 53 } // namespace
50 54
51 // static 55 // static
52 scoped_ptr<TestToolbarActionsBarHelper> 56 scoped_ptr<TestToolbarActionsBarHelper>
53 TestToolbarActionsBarHelper::Create(Browser* browser) { 57 TestToolbarActionsBarHelper::Create(Browser* browser,
54 return make_scoped_ptr(new TestToolbarActionsBarHelperViews(browser)); 58 TestToolbarActionsBarHelper* main_bar) {
59 return make_scoped_ptr(new TestToolbarActionsBarHelperViews(
60 browser,
61 static_cast<TestToolbarActionsBarHelperViews*>(main_bar)));
55 } 62 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698