[Extension Toolbar] Refactor and finish pop out logic for actions

chrome/browser/ui/cocoa/extensions/browser_actions_controller.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_EXTENSIONS_BROWSER_ACTIONS_CONTROLLER_H_
 #define CHROME_BROWSER_UI_COCOA_EXTENSIONS_BROWSER_ACTIONS_CONTROLLER_H_
 
 #import <Cocoa/Cocoa.h>
 
 #import "base/mac/scoped_nsobject.h"
@@ skipping 50 matching lines @@
   // The Browser Actions overflow menu.
   base::scoped_nsobject<NSMenu> overflowMenu_;
 }
 
 @property(readonly, nonatomic) BrowserActionsContainerView* containerView;
 
 // Initializes the controller given the current browser and container view that
 // will hold the browser action buttons.
 - (id)initWithBrowser:(Browser*)browser
         containerView:(BrowserActionsContainerView*)container
-           isOverflow:(BOOL)isOverflow;
+       mainController:(BrowserActionsController*)mainController;

[Avi (use Gerrit), 2014/12/12 23:53:59]

Document that parameter. "If this controller is for the overflow, then the
|mainController| parameter is of the controller for the main set of icons. If
|mainController| is nil, this controller is the controller of the main set of
icons" or something like that.

[Devlin, 2014/12/13 00:18:18]

Done.

 
 // Update the display of all buttons.
 - (void)update;
 
 // Returns the current number of browser action buttons within the container,
 // whether or not they are displayed.
 - (NSUInteger)buttonCount;
 
 // Returns the current number of browser action buttons displayed in the
 // container.
@@ skipping 17 matching lines @@
 @end  // @interface BrowserActionsController
 
 @interface BrowserActionsController(TestingAPI)
 - (BrowserActionButton*)buttonWithIndex:(NSUInteger)index;
 - (ToolbarActionsBar*)toolbarActionsBar;
 + (BrowserActionsController*)fromToolbarActionsBarDelegate:
     (ToolbarActionsBarDelegate*)delegate;
 @end
 
 #endif  // CHROME_BROWSER_UI_COCOA_EXTENSIONS_BROWSER_ACTIONS_CONTROLLER_H_