Source/core/rendering/RenderTable.cpp - Issue 766223004: Blocks should be aligned by style of parents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderTable.cpp

Issue 766223004: Blocks should be aligned by style of parents (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/table/rtl-within-right-alinged-div-expected.txt ('K') | « LayoutTests/fast/table/rtl-within-right-alinged-div-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderTable.cpp

diff --git a/Source/core/rendering/RenderTable.cpp b/Source/core/rendering/RenderTable.cpp

index df9a9aec096035c33130814be2ff2e569aa95ab6..8bd25f589f18f3b45cf677ca78448c5553d8e523 100644

--- a/Source/core/rendering/RenderTable.cpp

+++ b/Source/core/rendering/RenderTable.cpp

@@ -300,8 +300,10 @@ void RenderTable::updateLogicalWidth()

// Finally, with our true width determined, compute our margins for real.

ComputedMarginValues marginValues;

computeMarginsForDirection(InlineDirection, cb, availableLogicalWidth, logicalWidth(), marginValues.m_start, marginValues.m_end, style()->marginStart(), style()->marginEnd());

- setMarginStart(marginValues.m_start);

- setMarginEnd(marginValues.m_end);

+ bool hasInvertedDirection = cb->style()->isLeftToRightDirection() == style()->isLeftToRightDirection();

mstensho (USE GERRIT) 2014/12/04 09:47:57 This is a generic problem that doesn't only apply

Kyungtae Kim 2014/12/04 11:15:21 You're right. Both the code for RenderBox and Rend

+ setMarginStart(hasInvertedDirection ? marginValues.m_start : marginValues.m_end);

+ setMarginEnd(hasInvertedDirection ? marginValues.m_end : marginValues.m_start);

// We should NEVER shrink the table below the min-content logical width, or else the table can't accomodate

// its own content which doesn't match CSS nor what authors expect.

« LayoutTests/fast/table/rtl-within-right-alinged-div-expected.txt ('K') | « LayoutTests/fast/table/rtl-within-right-alinged-div-expected.txt ('k') | no next file » | no next file with comments »