Blocks should be aligned by style of parents

Source/core/rendering/RenderBox.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  *           (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 2091 matching lines @@
 
     // CSS 2.1: "If there is exactly one value specified as 'auto', its used value follows from the equality."
     if (marginEndLength.isAuto() && marginBoxWidth < availableWidth) {
         marginStart = marginStartWidth;
         marginEnd = availableWidth - childWidth - marginStart;
         return;
     }
 
     bool pushToEndFromTextAlign = !marginEndLength.isAuto() && ((!containingBlockStyle->isLeftToRightDirection() && containingBlockStyle->textAlign() == WEBKIT_LEFT)
         || (containingBlockStyle->isLeftToRightDirection() && containingBlockStyle->textAlign() == WEBKIT_RIGHT));
     if ((marginStartLength.isAuto() && marginBoxWidth < availableWidth) || pushToEndFromTextAlign) {

[mstensho (USE GERRIT), 2014/12/08 10:01:21]

Now handling of regular auto margins will be broken in twisted direction
situations:

<p>Should be yellow to the left, lime to the right.</p>
<div style="width:400px; background:yellow;" dir="rtl">
    <div style="margin-left:auto; width:200px; height:100px; background:lime;"
dir="ltr"></div>
</div>

I'll start a try job to see that we actually have tests for this. If not, one
should be written. Let's find out...

[Kyungtae Kim, 2014/12/09 04:53:08]

I included autoMargin cases in a new test case

-        marginEnd = marginEndWidth;
-        marginStart = availableWidth - childWidth - marginEnd;
+        if (containingBlockStyle->isLeftToRightDirection() != style()->isLeftToRightDirection()) {
+            marginStart = marginStartWidth;
+            marginEnd = availableWidth - childWidth - marginStart;
+        } else {
+            marginEnd = marginEndWidth;
+            marginStart = availableWidth - childWidth - marginEnd;
+        }
         return;
     }
 
     // Either no auto margins, or our margin box width is >= the container width, auto margins will just turn into 0.
     marginStart = marginStartWidth;
     marginEnd = marginEndWidth;
 }
 
 void RenderBox::updateLogicalHeight()
 {
@@ skipping 2304 matching lines @@
     computedValues.m_margins.m_end = marginEnd();
 
     setLogicalTop(oldLogicalTop);
     setLogicalWidth(oldLogicalWidth);
     setLogicalLeft(oldLogicalLeft);
     setMarginLeft(oldMarginLeft);
     setMarginRight(oldMarginRight);
 }
 
 } // namespace blink