LayoutTests/fast/dom/margin-for-inverted-direction.html - Issue 766223004: Blocks should be aligned by style of parents

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/margin-for-inverted-direction.html

Issue 766223004: Blocks should be aligned by style of parents (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: consider ltr in rtl Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2

	3 <style>

	4 div>div,div>table{border:1px black solid;width:50px;height:20px}

	5 </style>

	6

	7 <script src="../../resources/js-test.js"></script>

	8

	9 <div align="right">

	10 <table dir="rtl" border="1" id="rtl_table_in_ltr"><tr><td></td><td></td></tr>< /table>

	11 <div dir="rtl" id="rtl_div_in_ltr"></div>

	12 <table dir="ltr" border="1" id="ltr_table_in_ltr"><tr><td></td><td></td></tr>< /table>

	13 <div dir="ltr" id="ltr_div_in_ltr"></div>

	14 </div>

	15

	16 <div dir="rtl" align="left">

	17 <table dir="rtl" border="1" id="rtl_table_in_rtl"><tr><td></td><td></td></tr>< /table>

	18 <div dir="rtl" id="rtl_div_in_rtl"></div>

	19 <table dir="ltr" border="1" id="ltr_table_in_rtl"><tr><td></td><td></td></tr>< /table>

	20 <div dir="ltr" id="ltr_div_in_rtl"></div>

	21 </div>

	22

	23 <script>

	24 rtl_table_in_ltr = document.getElementById("rtl_table_in_ltr");

	25 rtl_div_in_ltr = document.getElementById("rtl_div_in_ltr");

	26 ltr_table_in_ltr = document.getElementById("ltr_table_in_ltr");

	27 ltr_div_in_ltr = document.getElementById("ltr_div_in_ltr");

	28 shouldBe("rtl_table_in_ltr.getBoundingClientRect().right","792");
	mstensho (USE GERRIT) 2014/12/08 10:01:21 Could you set a width on BODY or something, so tha Could you set a width on BODY or something, so that this test doesn't depend on window size? Kyungtae Kim 2014/12/09 04:53:08 Done. Set a width on BODY. Show quoted text On 2014/12/08 10:01:21, mstensho wrote: > Could you set a width on BODY or something, so that this test doesn't depend on > window size? Done. Set a width on BODY. mstensho (USE GERRIT) 2014/12/09 09:54:41 Acknowledged. Show quoted text On 2014/12/09 04:53:08, Kyungtae Kim wrote: > On 2014/12/08 10:01:21, mstensho wrote: > > Could you set a width on BODY or something, so that this test doesn't depend > on > > window size? > > Done. Set a width on BODY. Acknowledged.
	29 shouldBe("rtl_div_in_ltr.getBoundingClientRect().right","792");

	30 shouldBe("ltr_table_in_ltr.getBoundingClientRect().right","792");

	31 shouldBe("ltr_div_in_ltr.getBoundingClientRect().right","792");

	32

	33 rtl_table_in_rtl = document.getElementById("rtl_table_in_rtl");

	34 rtl_div_in_rtl = document.getElementById("rtl_div_in_rtl");

	35 ltr_table_in_rtl = document.getElementById("ltr_table_in_rtl");

	36 ltr_div_in_rtl = document.getElementById("ltr_div_in_rtl");

	37 shouldBe("rtl_table_in_rtl.getBoundingClientRect().left","8");

	38 shouldBe("rtl_div_in_rtl.getBoundingClientRect().left","8");

	39 shouldBe("ltr_table_in_rtl.getBoundingClientRect().left","8");

	40 shouldBe("ltr_div_in_rtl.getBoundingClientRect().left","8");

	41 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/margin-for-inverted-direction-expected.txt » ('j') | Source/core/rendering/RenderBox.cpp » ('J')