Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 766193006: exc_server_variants: Templatize and use CompositeMachMessageServer (Closed)

Created:
6 years ago by Mark Mentovai
Modified:
6 years ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

exc_server_variants: Templatize and use CompositeMachMessageServer. The implementations for the exc and mach_exc subsystems were nearly identical, and were a good target for templatization. The existing split between exc and mach_exc was a good candidate for unification based on CompositeMachMessageServer instead of the custom unification previously done in UniversalMachMessageServer. TEST=util_test ExcServerVariants.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/508a33dc7ae7da99abbc5cf4756c872388b9fea6

Patch Set 1 #

Patch Set 2 : Fix comment #

Total comments: 1

Patch Set 3 : Address review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+507 lines, -958 lines) Patch
M util/mach/exc_server_variants.h View 1 2 5 chunks +21 lines, -439 lines 0 comments Download
M util/mach/exc_server_variants.cc View 1 5 chunks +486 lines, -519 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
This is a net reduction of 448 lines!
6 years ago (2014-12-04 23:19:49 UTC) #2
Robert Sesek
LGTM https://codereview.chromium.org/766193006/diff/20001/util/mach/exc_server_variants.h File util/mach/exc_server_variants.h (right): https://codereview.chromium.org/766193006/diff/20001/util/mach/exc_server_variants.h#newcode116 util/mach/exc_server_variants.h:116: // Pointer-to-implementation (pimpl). The implementation relies on internal ...
6 years ago (2014-12-11 16:32:28 UTC) #3
Mark Mentovai
6 years ago (2014-12-11 19:29:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
508a33dc7ae7da99abbc5cf4756c872388b9fea6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698