Make template scan related function take a template<bool> parameter

Make template scan related function take a template<bool> parameter

This is for performance. Having to do the test in every Advance was too
expensive.

BUG=438991, v8:3230
LOG=N
R=dslomov@chromium.org, marja

[arv (Not doing code reviews), 2014-12-04 17:03:40]

PTAL

I'm tempted to use a template<bool> so that the overhead for ordinary strings
would be 0. WDYT?

[Dmitry Lomov (no reviews), 2014-12-04 17:47:30]

On 2014/12/04 17:03:40, arv wrote:
> PTAL
> 
> I'm tempted to use a template<bool> so that the overhead for ordinary strings
> would be 0. WDYT?

template<bool> sgtm.

[arv (Not doing code reviews), 2014-12-04 17:51:00]

Change to use template<bool> and remove extra work from LiteralScope

[arv (Not doing code reviews), 2014-12-04 17:52:16]

Changed to template<bool>

PTAL

[caitp (gmail), 2014-12-04 17:59:43]

On 2014/12/04 17:52:16, arv wrote:
> Changed to template<bool>
> 
> PTAL

Another toolchain question: can we use default function template arguments? I
think it was being discussed on blink-dev recently, I didn't pay attention to
the verdict on that though.

[Dmitry Lomov (no reviews), 2014-12-04 18:04:23]

lgtm

https://codereview.chromium.org/766193003/diff/20001/src/scanner.h
File src/scanner.h (right):

https://codereview.chromium.org/766193003/diff/20001/src/scanner.h#newcode549
src/scanner.h:549: inline void TerminateLiteral() {
Nit: if it does nothing, why not remove it?

[arv (Not doing code reviews), 2014-12-04 18:07:09]

https://codereview.chromium.org/766193003/diff/20001/src/scanner.h
File src/scanner.h (right):

https://codereview.chromium.org/766193003/diff/20001/src/scanner.h#newcode549
src/scanner.h:549: inline void TerminateLiteral() {
On 2014/12/04 18:04:23, Dmitry Lomov (chromium) wrote:
> Nit: if it does nothing, why not remove it?

Old code... I guess at some point it did something...

There is a "contract" that certain functions only return valid values between
StartLiteral and TerminateLiteral. I'll see if I can make the comment clear
after removing TerminateLiteral.

[arv (Not doing code reviews), 2014-12-04 18:15:35]

Remove empty TerminateLiteral and use default template param

[arv (Not doing code reviews), 2014-12-04 18:57:53]

The CQ bit was checked by arv@chromium.org

[commit-bot: I haz the power, 2014-12-04 18:58:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/766193003/40001

[commit-bot: I haz the power, 2014-12-04 19:24:23]

Committed patchset #3 (id:40001)