Issue 766183004: Dispose of DOMTimer upon explicit ExecutionContext unregistration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 766183004: Dispose of DOMTimer upon explicit ExecutionContext unregistration. (Closed)

Created:
6 years ago by sof

Modified:
6 years ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Dispose of DOMTimer upon explicit ExecutionContext unregistration. Follow up on r186385 and explicitly dispose&stop a DOMTimer when it is removed from its associated ExecutionContext. Needed for Oilpan, as the now-GCed object will only later be finalized. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186425

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -0 lines)			Patch
M	Source/core/dom/ExecutionContext.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/core/frame/DOMTimer.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/frame/DOMTimer.cpp	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sof

Please take a look. Some DOMTimer-related failures currently seen on trunk.

6 years ago (2014-12-03 12:45:32 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/766183004/1

6 years ago (2014-12-03 14:07:52 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-03 15:14:13 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186425

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages