Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1778)

Unified Diff: content/browser/renderer_host/render_message_filter.cc

Issue 766173003: Make RenderMessageCompletionCallback delete unsent Message (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gah, clear reply_msg_ Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_message_filter.cc
diff --git a/content/browser/renderer_host/render_message_filter.cc b/content/browser/renderer_host/render_message_filter.cc
index 9d8392778e136044efe6c051f04ee55e8bc9bd0a..449afb4d4ea29a453fdb0a6758417dd59337218a 100644
--- a/content/browser/renderer_host/render_message_filter.cc
+++ b/content/browser/renderer_host/render_message_filter.cc
@@ -131,6 +131,12 @@ class RenderMessageCompletionCallback {
}
virtual ~RenderMessageCompletionCallback() {
+ if (reply_msg_) {
+ // If the owner of this class failed to call SendReplyAndDeleteThis(),
+ // send an error reply to prevent the renderer from being hung.
+ reply_msg_->set_reply_error();
+ filter_->Send(reply_msg_);
+ }
}
RenderMessageFilter* filter() { return filter_.get(); }
@@ -138,6 +144,7 @@ class RenderMessageCompletionCallback {
void SendReplyAndDeleteThis() {
filter_->Send(reply_msg_);
+ reply_msg_ = NULL;
delete this;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698