Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 766163002: SVG font support was removed from Blink, deleting SVG test cases (Closed)

Created:
6 years ago by h.joshi
Modified:
6 years ago
Reviewers:
pdr., eae
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Delete SVG font tests after SVG fonts were removed. This patch removes 3 tests that depended on SVG fonts which were removed in https://src.chromium.org/viewvc/blink?view=rev&revision=184321. BUG=242735 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186388

Patch Set 1 #

Patch Set 2 : Rebasing Test Expecation #

Total comments: 6

Patch Set 3 : Comment fixes #

Total comments: 1

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -238 lines) Patch
D LayoutTests/platform/linux/svg/text/text-overflow-ellipsis-svgfont-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/svg/text/text-overflow-ellipsis-svgfont-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/platform/mac/svg/text/text-overflow-ellipsis-svgfont-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/svg/text/text-overflow-ellipsis-svgfont-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/platform/win-xp/svg/text/text-overflow-ellipsis-svgfont-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/svg/text/text-overflow-ellipsis-svgfont-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/platform/win-xp/virtual/textblob/svg/text/text-overflow-ellipsis-svgfont-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/virtual/textblob/svg/text/text-overflow-ellipsis-svgfont-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/platform/win/svg/text/text-overflow-ellipsis-svgfont-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/svg/text/text-overflow-ellipsis-svgfont-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
M LayoutTests/svg/css/font-face-variant-crash.html View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/svg/css/font-face-variant-crash-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/svg/custom/svg-fonts-in-html-linebreaks.html View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/svg/custom/svg-fonts-in-html-linebreaks-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/svg/text/text-overflow-ellipsis-svgfont.html View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
h.joshi
Pls review
6 years ago (2014-12-02 05:37:03 UTC) #2
eae
pdr should review this
6 years ago (2014-12-02 16:39:41 UTC) #4
pdr.
https://codereview.chromium.org/766163002/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/766163002/diff/20001/LayoutTests/TestExpectations#newcode1405 LayoutTests/TestExpectations:1405: # Test case needs to be updated after https://codereview.chromium.org/680213004/ ...
6 years ago (2014-12-02 18:14:12 UTC) #5
h.joshi
@pdr: Suggested changes are done, pls review. https://codereview.chromium.org/766163002/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/766163002/diff/20001/LayoutTests/TestExpectations#newcode1405 LayoutTests/TestExpectations:1405: # Test ...
6 years ago (2014-12-03 04:27:44 UTC) #6
pdr.
Please remove the "from Layout test" line in your change description. We try to have ...
6 years ago (2014-12-03 04:47:21 UTC) #7
h.joshi
@pdr: Issue descriptions is changed. Test case "font-face-variant-crash.html" was deleted, as right side "new" in ...
6 years ago (2014-12-03 05:44:23 UTC) #9
pdr.
Wonderful. Thanks! LGTM
6 years ago (2014-12-03 05:47:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/766163002/80001
6 years ago (2014-12-03 05:48:36 UTC) #12
h.joshi
@pdr: thank you
6 years ago (2014-12-03 06:39:51 UTC) #13
commit-bot: I haz the power
6 years ago (2014-12-03 07:34:22 UTC) #14
Message was sent while issue was closed. 
Committed patchset #4 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186388

Powered by Google App Engine
This is Rietveld 408576698