LayoutTests/fast/events/menu-key-context-menu-element-focus.html - Issue 766143002: Fix contextmenu event location for menu key in an iframe

Unified Diff: LayoutTests/fast/events/menu-key-context-menu-element-focus.html

Issue 766143002: Fix contextmenu event location for menu key in an iframe (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Changes as per review comments. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/NeverFixTests ('k') | LayoutTests/fast/events/menu-key-context-menu-element-focus-expected.txt » ('j') | Source/core/page/EventHandler.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/events/menu-key-context-menu-element-focus.html

diff --git a/LayoutTests/fast/events/menu-key-context-menu.html b/LayoutTests/fast/events/menu-key-context-menu-element-focus.html

similarity index 62%

copy from LayoutTests/fast/events/menu-key-context-menu.html

copy to LayoutTests/fast/events/menu-key-context-menu-element-focus.html

index 586d182d1835610bf03992353490617fb8199ecf..01889b447e357e8e6d7d68a794f6148dd0d6aba4 100644

--- a/LayoutTests/fast/events/menu-key-context-menu.html

+++ b/LayoutTests/fast/events/menu-key-context-menu-element-focus.html

@@ -5,18 +5,21 @@ Test for contextmenu event target

</title>

</head>

-<p>This test checks if contextmenu event target is correct when triggered from menu key.</p>

+<p>This test checks if focus is on same element after dismissing context menu

+ by esc key context menu came by menu key selection, so that when menu key is

+ selected context menu will come on that element.</p>

var count = 0;

+var anchorNode;

function handleContextMenu(e) {

count++;

- if(count === 2)

+ if(count === 2 && (e.currentTarget == anchorNode)) {

Rick Byers 2014/12/10 03:09:24 Does this test actually fail without your patch?

Deepak 2014/12/10 06:40:27 No , This test is not failing without my changes.

No , This test is not failing without my changes.

Actually when you load http://jsfiddle.net/kvckb90w/2/show/ * Use tab key to bring focus on one of the buttons * Hit the context menu key Then context menu does not come on the button but off the button and on selecting 'esc' key, Button will lose focus and then again selecting 'Context menu' key context menu will come at the top left corner and context menu items are also different. But I am surprised that in the test case doing document.activeElement after hitting 'esc' giving still 'anchor' element as focused element.

I tried this, But still the test case is getting passed, as 'Anchor' element is not losing focus after scroll. I have added a padding in para as: <style> p.ex1 { padding: 100px 100px; } </style> <a href="" id="anchor" oncontextmenu="handleContextMenu(event);">Test</a> <div id="result">FAIL</div> <p class="ex1">Padding.</p> and call as: anchor.focus(); eventSender.keyDown("menu"); eventSender.keyDown("escape"); window.scroll(0,200); eventSender.keyDown("menu"); but as 'Anchor' element doesn't lose focus in test case, so it is getting passed even without my change. But in the issue case 'Button' is losing focus, as context menu is not on the button.

document.getElementById("result").innerHTML = "PASS";

+ }

return false;

}

function test() {

if (window.testRunner)

testRunner.dumpAsText();

@@ -24,18 +27,12 @@ function test() {

if (!window.eventSender)

return;

- var anchor = document.getElementById("anchor");

- var r = anchor.getBoundingClientRect();

- var x = (r.left + r.right) / 2

- var y = (r.top + r.bottom) / 2;

- eventSender.mouseMoveTo(x, y);

- eventSender.contextClick();

+ anchorNode = document.getElementById("anchor");

+ anchor.focus();

+ eventSender.keyDown("menu");

// Esc key to hide context menu

eventSender.keyDown("escape");

- anchor.focus();

eventSender.keyDown("menu");

}

</script>

</body>

« no previous file with comments | « LayoutTests/NeverFixTests ('k') | LayoutTests/fast/events/menu-key-context-menu-element-focus-expected.txt » ('j') | Source/core/page/EventHandler.cpp » ('J')