LayoutTests/fast/events/menu-key-context-menu-position.html - Issue 766143002: Fix contextmenu event location for menu key in an iframe

Side by Side Diff: LayoutTests/fast/events/menu-key-context-menu-position.html

Issue 766143002: Fix contextmenu event location for menu key in an iframe (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added description of testcase. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/NeverFixTests ('k') | LayoutTests/fast/events/menu-key-context-menu-position-expected.txt » ('j') | LayoutTests/fast/events/menu-key-context-menu-position-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <body>

	3 <script src="../../resources/js-test.js"></script>

	4 <script src="../dom/resources/event-sender-util.js"></script>

	5 <script>

	6 var anchorNode;

	7 var x,y;

	8 description('Verifies that when element is focused in frames then selection'+

	9 ' by menu key, context menu should come on focused element. Succeeds if '+

	10 'context menu is coming on the focused element and event co-ordinates are'+

	11 ' at center of the elements bounding box.');

	12 function onEventInFrame(e) {

	13 shouldBe(e.target, anchorNode);
	Rick Byers 2015/01/05 18:16:24 shouldBe takes expression strings to be evaluated, shouldBe takes expression strings to be evaluated, not values. This is why I wrote examples like this: shouldBe("event.target", "anchorNode"); One benefit here is that you probably don't really want the value of "e.clientX" appearing in the test output - it might be slightly different on different platforms or change for unrelated reasons. You don't care what the value is, just that it matches what the test expects. I'm surprised to hear you get the "not a string" warnings only when using iframes - I would have expected you to see those warnings unconditionally. Probably suggests something is broken with the test output in the frameset case. Deepak 2015/01/06 13:27:02 Earlier the issue is we can not use frameset insid Show quoted text On 2015/01/05 18:16:24, Rick Byers wrote: > shouldBe takes expression strings to be evaluated, not values. This is why I > wrote examples like this: > shouldBe("event.target", "anchorNode"); > > One benefit here is that you probably don't really want the value of "e.clientX" > appearing in the test output - it might be slightly different on different > platforms or change for unrelated reasons. You don't care what the value is, > just that it matches what the test expects. > > I'm surprised to hear you get the "not a string" warnings only when using > iframes - I would have expected you to see those warnings unconditionally. > Probably suggests something is broken with the test output in the frameset case. Earlier the issue is we can not use frameset inside body tag. I have removed body tag as well as frameset. and using iframes as you suggested earlier. Now I am using menu-key-context-menu-document.html as reference for comparing event.target.id, and I need to convert event.clientX/Y to String() so that it can be used in the shouldbe. Now I am getting PASS for all 3 shouldbe() calls as shown in the expected result.
	14 shouldBe(e.clientX, x);

	15 shouldBe(e.clientY, y);

	16 }

	17 function runTest() {

	18 if (window.testRunner)

	19 testRunner.dumpAsText();

	20 if (!window.eventSender)

	21 return;

	22 anchorNode = frames[1].document.getElementById("ex1");

	23 var r = anchorNode.getBoundingClientRect();

	24 x = (r.left + r.right) / 2

	25 y = (r.top + r.bottom) / 2;

	26 anchorNode.focus();

	27 eventSender.keyDown("menu");

	28 }

	29 </script>

	30 <frameset rows="30%,40%" onload="runTest()">

	31 <frame src="resources/window-opened.html">

	32 <frame id="myframe" src="resources/menu-key-context-menu-position-frame.html">

	33 </frameset>

	34 </body>

OLD	NEW