LayoutTests/fast/events/menu-key-context-menu-position.html - Issue 766143002: Fix contextmenu event location for menu key in an iframe

Side by Side Diff: LayoutTests/fast/events/menu-key-context-menu-position.html

Issue 766143002: Fix contextmenu event location for menu key in an iframe (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <html>

	3 <head>
	Rick Byers 2014/12/19 15:14:27 Nit: omit html and head tags. See http://www.chro Nit: omit html and head tags. See http://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-h... Deepak 2014/12/20 09:35:33 Done. Show quoted text On 2014/12/19 15:14:27, Rick Byers (Out until 12-5) wrote: > Nit: omit html and head tags. See > http://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-h... Done.
	4 <script>

	5 var count = 0;

	6 var anchorNode;

	7 var x,y;

	8 function onEventInFrame(e) {

	9 count++;

	10 if(count === 2) {

	11 if (e.target == anchorNode && e.clientX === x && e.clientY === y)
	Rick Byers 2014/12/19 15:14:27 this is what the 'shouldBe' helpers are for in js- this is what the 'shouldBe' helpers are for in js-test.js. So this should become something like: var event; function onEventInIframe(e) { shouldBe("event.target", "anchorNode"); shouldBe("event.clientX", "expectedX"); shouldBe("event.clientY", "expectedY"); } Also, once you're using js-test.js, please add a 'description()' call. See, for example, fast/events/touch/gesture/gesture-tap-div-removed.html for a layout test that follows the style expected for new tests. Deepak 2014/12/20 09:35:33 I have tried to use description() but I am not abl Show quoted text On 2014/12/19 15:14:27, Rick Byers (Out until 12-5) wrote: > this is what the 'shouldBe' helpers are for in js-test.js. So this should > become something like: > > var event; > function onEventInIframe(e) { > shouldBe("event.target", "anchorNode"); > shouldBe("event.clientX", "expectedX"); > shouldBe("event.clientY", "expectedY"); > } I have tried to use description() but I am not able to get that in the expected results files. Show quoted text > Also, once you're using js-test.js, please add a 'description()' call. See, for > example, fast/events/touch/gesture/gesture-tap-div-removed.html for a layout > test that follows the style expected for new tests.
	12 alert("PASS");

	13 else

	14 alert("FAIL");

	15 }

	16 return false;

	17 }

	18 function runTest() {

	19 if (window.testRunner)

	20 testRunner.dumpAsText();

	21 if (!window.eventSender)

	22 return;

	23 anchorNode = frames[1].document.getElementById("ex1");

	24 var r = anchorNode.getBoundingClientRect();

	25 x = (r.left + r.right) / 2

	26 y = (r.top + r.bottom) / 2;

	27 anchorNode.focus();

	28 eventSender.keyDown("menu");

	29 // Esc key to hide context menu
	Rick Byers 2014/12/19 15:14:27 Any reason to do this twice? I'd suggest removing Any reason to do this twice? I'd suggest removing the below two lines (and looking only at the first contextmenu event) - if I understand the problem properly, they don't add anything to the test... Deepak 2014/12/20 09:35:33 Done. Show quoted text On 2014/12/19 15:14:27, Rick Byers (Out until 12-5) wrote: > Any reason to do this twice? I'd suggest removing the below two lines (and > looking only at the first contextmenu event) - if I understand the problem > properly, they don't add anything to the test... Done.
	30 eventSender.keyDown("escape");

	31 eventSender.keyDown("menu");

	32 }

	33 </script>

	34 </head>

	35

	36 <frameset rows="30%,40%" onload="runTest()">
	Rick Byers 2014/12/19 15:14:27 perhaps the frameset is necessary just to get "myf perhaps the frameset is necessary just to get "myframe" to be positioned somewhere other than (0,0)? I'd expect this to work just as well and be simpler: <iframe id="myframe" style="margin-top: 50px;" onload="runTest()" src="resources/menu-key-context-menu-position-frame.html"> Deepak 2014/12/20 09:35:33 I am getting uncaught reference error like below Show quoted text On 2014/12/19 15:14:27, Rick Byers (Out until 12-5) wrote: > perhaps the frameset is necessary just to get "myframe" to be positioned > somewhere other than (0,0)? I'd expect this to work just as well and be > simpler: > > <iframe id="myframe" style="margin-top: 50px;" onload="runTest()" > src="resources/menu-key-context-menu-position-frame.html"> I am getting uncaught reference error like below when I have iframes in Frameset. OR I tried to used iframes without frameset. "CONSOLE ERROR: line 38: Uncaught ReferenceError: runTest is not defined PASS successfullyParsed is true" So I have to use frames only.
	37 <frame src="resources/window-opened.html">

	38 <frame id="myframe" src="resources/menu-key-context-menu-position-frame.html">

	39 </frameset>

	40

	41 </html>

OLD	NEW

« no previous file with comments | « LayoutTests/NeverFixTests ('k') | LayoutTests/fast/events/menu-key-context-menu-position-expected.txt » ('j') | no next file with comments »