remoting/host/plugin/policy_hack/nat_policy.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/plugin/policy_hack/nat_policy.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/host/plugin/policy_hack/nat_policy.cc

diff --git a/remoting/host/plugin/policy_hack/nat_policy.cc b/remoting/host/plugin/policy_hack/nat_policy.cc

index 07a28def2579994ef4ed9f93e353624240e07ecb..4ca7480fcbc5e3d9879694df4c3785f7e3fac36c 100644

--- a/remoting/host/plugin/policy_hack/nat_policy.cc

+++ b/remoting/host/plugin/policy_hack/nat_policy.cc

@@ -95,10 +95,8 @@ void NatPolicy::UpdateNatPolicy(base::DictionaryValue* new_policy) {

// Otherwise, try to parse the value and only change from false if we get

// a successful read.

base::Value* value;

- if (new_policy->Get(kNatPolicyName, &value) &&

- value->IsType(base::Value::TYPE_BOOLEAN)) {

+ if (new_policy->Get(kNatPolicyName, &value) && value->IsBoolean())

CHECK(value->GetAsBoolean(&new_nat_enabled_state));

- }

}

if (!first_state_published_ ||