Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Unified Diff: content/browser/geolocation/network_location_request.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tony review Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/debugger/devtools_netlog_observer.cc ('k') | content/browser/gpu/gpu_blacklist.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/geolocation/network_location_request.cc
diff --git a/content/browser/geolocation/network_location_request.cc b/content/browser/geolocation/network_location_request.cc
index deedc926ea1aa7b9786c1208b8fa13c55835a00e..14f29cad1ee09c8d3b9e3961d16f4f1f43fefe08 100644
--- a/content/browser/geolocation/network_location_request.cc
+++ b/content/browser/geolocation/network_location_request.cc
@@ -311,7 +311,7 @@ bool ParseServerResponse(const std::string& response_body,
return false;
}
- if (!response_value->IsType(Value::TYPE_DICTIONARY)) {
+ if (!response_value->IsDictionary()) {
VLOG(1) << "ParseServerResponse() : Unexpected resopnse type "
<< response_value->GetType();
return false;
@@ -332,8 +332,8 @@ bool ParseServerResponse(const std::string& response_body,
}
DCHECK(location_value);
- if (!location_value->IsType(Value::TYPE_DICTIONARY)) {
- if (!location_value->IsType(Value::TYPE_NULL)) {
+ if (!location_value->IsDictionary()) {
+ if (!location_value->IsNull()) {
VLOG(1) << "ParseServerResponse() : Unexpected location type "
<< location_value->GetType();
// If the network provider was unable to provide a position fix, it should
« no previous file with comments | « content/browser/debugger/devtools_netlog_observer.cc ('k') | content/browser/gpu/gpu_blacklist.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698