chrome/test/webdriver/webdriver_dispatch_unittest.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/webdriver/webdriver_dispatch_unittest.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/webdriver/webdriver_dispatch_unittest.cc

diff --git a/chrome/test/webdriver/webdriver_dispatch_unittest.cc b/chrome/test/webdriver/webdriver_dispatch_unittest.cc

index 4f25c7d8af9ca2d1baa65b0e7c1e3808955fe118..85f2be439df84faf4961294080683f483997dc13 100644

--- a/chrome/test/webdriver/webdriver_dispatch_unittest.cc

+++ b/chrome/test/webdriver/webdriver_dispatch_unittest.cc

@@ -136,7 +136,7 @@ TEST(DispatchTest, ReturnsCommandResponseAsJson) {

actual_data, false, &error_code, &error_message));

ASSERT_TRUE(parsed_response.get() != NULL) << error_message;

- ASSERT_TRUE(parsed_response->IsType(Value::TYPE_DICTIONARY))

+ ASSERT_TRUE(parsed_response->IsDictionary())

<< "Response should be a dictionary: " << actual_data;

DictionaryValue* dict = static_cast<DictionaryValue*>(parsed_response.get());