Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9438)

Unified Diff: chrome/test/automation/value_conversion_traits.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tony review Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/automation/tab_proxy.cc ('k') | chrome/test/base/ui_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/automation/value_conversion_traits.cc
diff --git a/chrome/test/automation/value_conversion_traits.cc b/chrome/test/automation/value_conversion_traits.cc
index f5c1f2c00ac66f7278b5cffa3243705ed2ac72dd..5c437828e286b380f4516fb8d463123a0ace9922 100644
--- a/chrome/test/automation/value_conversion_traits.cc
+++ b/chrome/test/automation/value_conversion_traits.cc
@@ -71,14 +71,14 @@ Value* ValueConversionTraits<ListValue*>::CreateValueFrom(const ListValue* t) {
bool ValueConversionTraits<ListValue*>::SetFromValue(const Value* value,
ListValue** t) {
- if (!value->IsType(Value::TYPE_LIST))
+ if (!value->IsList())
return false;
*t = static_cast<const ListValue*>(value)->DeepCopy();
return true;
}
bool ValueConversionTraits<ListValue*>::CanConvert(const Value* value) {
- return value->IsType(Value::TYPE_LIST);
+ return value->IsList();
}
Value* ValueConversionTraits<DictionaryValue*>::CreateValueFrom(
@@ -88,12 +88,12 @@ Value* ValueConversionTraits<DictionaryValue*>::CreateValueFrom(
bool ValueConversionTraits<DictionaryValue*>::SetFromValue(
const Value* value, DictionaryValue** t) {
- if (!value->IsType(Value::TYPE_DICTIONARY))
+ if (!value->IsDictionary())
return false;
*t = static_cast<const DictionaryValue*>(value)->DeepCopy();
return true;
}
bool ValueConversionTraits<DictionaryValue*>::CanConvert(const Value* value) {
- return value->IsType(Value::TYPE_DICTIONARY);
+ return value->IsDictionary();
}
« no previous file with comments | « chrome/test/automation/tab_proxy.cc ('k') | chrome/test/base/ui_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698