chrome/renderer/extensions/extension_api_json_validity_unittest.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/extension_api_json_validity_unittest.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/extension_api_json_validity_unittest.cc

diff --git a/chrome/renderer/extensions/extension_api_json_validity_unittest.cc b/chrome/renderer/extensions/extension_api_json_validity_unittest.cc

index 414c6c343307945b31fd75061f17c2b8633468a4..c52c065547d56641f4035b4ed7fc4d4592604e11 100644

--- a/chrome/renderer/extensions/extension_api_json_validity_unittest.cc

+++ b/chrome/renderer/extensions/extension_api_json_validity_unittest.cc

@@ -33,7 +33,7 @@ bool FindDictionaryWithProperyValue(ListValue* list,

std::string* out_error_message) {

bool found = false;

for (ListValue::const_iterator it = list->begin(); it != list->end(); ++it) {

- if (!(*it)->IsType(Value::TYPE_DICTIONARY)) {

+ if (!(*it)->IsDictionary()) {

*out_error_message = "List contains an item taht is not a dictionary.";

return false;

}