chrome/common/json_schema_validator_unittest_base.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/json_schema_validator_unittest_base.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/json_schema_validator_unittest_base.cc

diff --git a/chrome/common/json_schema_validator_unittest_base.cc b/chrome/common/json_schema_validator_unittest_base.cc

index 5a9112304ffda419f984bb3612a1100709fff461..3c7d753d22621fdd7342aab63e577262d42e35ec 100644

--- a/chrome/common/json_schema_validator_unittest_base.cc

+++ b/chrome/common/json_schema_validator_unittest_base.cc

@@ -40,7 +40,7 @@ Value* LoadValue(const std::string& filename, base::Value::Type type) {

scoped_ptr<Value> result(LoadValue(filename));

if (!result.get())

return NULL;

- if (!result->IsType(type)) {

+ if (result->GetType() != type) {

ADD_FAILURE() << "Expected type " << type << ", got: " << result->GetType();

return NULL;

}