chrome/common/extensions/extension_unpacker.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_unpacker.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension_unpacker.cc

diff --git a/chrome/common/extensions/extension_unpacker.cc b/chrome/common/extensions/extension_unpacker.cc

index 9a06bbc34b99813f8323c6f8f696c2b69954c1ae..c38444ec78277870504fce2539cc85cb96217afd 100644

--- a/chrome/common/extensions/extension_unpacker.cc

+++ b/chrome/common/extensions/extension_unpacker.cc

@@ -107,7 +107,7 @@ DictionaryValue* ExtensionUnpacker::ReadManifest() {

return NULL;

}

- if (!root->IsType(Value::TYPE_DICTIONARY)) {

+ if (!root->IsDictionary()) {

SetError(errors::kInvalidManifest);

return NULL;

}

« no previous file with comments | « chrome/common/extensions/extension_file_util.cc ('k') | chrome/common/json_pref_store.cc » ('j') | no next file with comments »