chrome/common/extensions/extension.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension.cc

diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc

index 86268cd76bcbf7b9a218826b617db98a4ede7818..b9157b6b52a07d4f2a6dc9ae13257c4937829c0b 100644

--- a/chrome/common/extensions/extension.cc

+++ b/chrome/common/extensions/extension.cc

@@ -762,7 +762,7 @@ Extension::FileBrowserHandlerList* Extension::LoadFileBrowserHandlers(

for (ListValue::const_iterator iter = extension_actions->begin();

iter != extension_actions->end();

++iter) {

- if (!(*iter)->IsType(Value::TYPE_DICTIONARY)) {

+ if (!(*iter)->IsDictionary()) {

*error = errors::kInvalidFileBrowserHandler;

return NULL;

}