Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: chrome/browser/web_resource/promo_resource_service.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tony review Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/sync_setup_handler.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_resource/promo_resource_service.cc
diff --git a/chrome/browser/web_resource/promo_resource_service.cc b/chrome/browser/web_resource/promo_resource_service.cc
index dd242f3561064e4a3ea58a1ed510f1d8a90f05b8..eef824d8751a8e2a5bea49a01ac16af10fd9041a 100644
--- a/chrome/browser/web_resource/promo_resource_service.cc
+++ b/chrome/browser/web_resource/promo_resource_service.cc
@@ -226,7 +226,7 @@ void PromoResourceService::UnpackPromoSignal(
int time_slice_hrs = 0;
for (ListValue::const_iterator answer_iter = answer_list->begin();
answer_iter != answer_list->end(); ++answer_iter) {
- if (!(*answer_iter)->IsType(Value::TYPE_DICTIONARY))
+ if (!(*answer_iter)->IsDictionary())
continue;
DictionaryValue* a_dic =
static_cast<DictionaryValue*>(*answer_iter);
@@ -318,7 +318,7 @@ void PromoResourceService::UnpackWebStoreSignal(
for (ListValue::const_iterator answer_iter = answer_list->begin();
answer_iter != answer_list->end(); ++answer_iter) {
- if (!(*answer_iter)->IsType(Value::TYPE_DICTIONARY))
+ if (!(*answer_iter)->IsDictionary())
continue;
DictionaryValue* a_dic =
static_cast<DictionaryValue*>(*answer_iter);
@@ -410,7 +410,7 @@ void PromoResourceService::UnpackLogoSignal(
std::string logo_end_string = "";
for (ListValue::const_iterator answer_iter = answer_list->begin();
answer_iter != answer_list->end(); ++answer_iter) {
- if (!(*answer_iter)->IsType(Value::TYPE_DICTIONARY))
+ if (!(*answer_iter)->IsDictionary())
continue;
DictionaryValue* a_dic =
static_cast<DictionaryValue*>(*answer_iter);
« no previous file with comments | « chrome/browser/ui/webui/sync_setup_handler.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698