chrome/browser/ui/webui/print_preview_handler.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/print_preview_handler.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/print_preview_handler.cc

diff --git a/chrome/browser/ui/webui/print_preview_handler.cc b/chrome/browser/ui/webui/print_preview_handler.cc

index d904c18a5f2d9bc59a888d9aba7055fb5cdca3f3..7e370eca907be00a8b70270bfa5a6165246c188c 100644

--- a/chrome/browser/ui/webui/print_preview_handler.cc

+++ b/chrome/browser/ui/webui/print_preview_handler.cc

@@ -113,7 +113,7 @@ DictionaryValue* GetSettingsDictionary(const ListValue* args) {

}

scoped_ptr<DictionaryValue> settings(static_cast<DictionaryValue*>(

base::JSONReader::Read(json_str, false)));

- if (!settings.get() || !settings->IsType(Value::TYPE_DICTIONARY)) {

+ if (!settings.get() || !settings->IsDictionary()) {

NOTREACHED() << "Print job settings must be a dictionary.";

return NULL;

}